Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

writer: ignore "context canceled" error on Discard #19

Merged
merged 5 commits into from
Jan 8, 2020
Merged

writer: ignore "context canceled" error on Discard #19

merged 5 commits into from
Jan 8, 2020

Conversation

mxmCherry
Copy link
Contributor

It is expected on Discard, as context is canceled first and then few Close-s are attempted.

mxmCherry and others added 2 commits January 7, 2020 18:41
@mxmCherry
writer: ignore "context canceled" error on Discard
ce709b4 
It is expected on Discard, as context is canceled first and then few Close-s are attempted.
@mxmCherry
cosmetics: tabs, not spaces
2342771
@mxmCherry
Copy link
Contributor Author

mxmCherry commented Jan 7, 2020 •
edited
Loading

@bsm build fails due to no errors.Is(...); do we want to support older go?

@dim
Copy link
Member

dim commented Jan 7, 2020

@bsm build fails due to no errors.Is(...); do we want to support older go?

yes, remove <1.13

@dim
Copy link
Member

dim commented Jan 8, 2020

Needs rubocop fixes too pls

@mxmCherry
hk: rubocop, auto-correcting issues
a48129f
@mxmCherry
travis: no ruby 2.7 yet
112003f 
google-protobuf gem is not ready for ruby 2.7 yet
@dim dim merged commit f238682 into bsm:master Jan 8, 2020
@mxmCherry mxmCherry deleted the patch-1 branch January 9, 2020 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mxmCherry @dim