Pusher factories #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mxmCherry
reviewed
Nov 22, 2018
| @@ -4,13 +4,22 @@ | |||
| module Feedx | |||
| # Pushes a relation as a protobuf encoded stream to an S3 location. | |||
| class Pusher | |||
| # @param [Enumerable,ActiveRecord::Relation] relation to stream. | |||
| # See constructor. | |||
| def self.perform(url, opts={}, &block) | |||
There was a problem hiding this comment.
IMO, doesn't add much value (doesn't save much code)
| # @param [String] url the destination URL. | ||
| # @param [Hash] opts options | ||
| # @option opts [Enumerable,ActiveRecord::Relation] :enum relation or enumerator to stream. |
There was a problem hiding this comment.
IMO, just another option to know/remember about, but doesn't actually add much value. I think accepting block is more than enough.
| enum = @relation.respond_to?(:find_each) ? :find_each : :each | ||
| @relation.send(enum) {|rec| stream.write(rec) } | ||
| stream = @format.new(io) | ||
| relation = @enum.is_a?(Proc) ? @enum.call : @enum |
There was a problem hiding this comment.
I'd just check @enum.respond_to?(:call) (really doesn't matter, but would allow not only Proc passed but also some custom class/object with call method; though t makes sense only if :enum option is going to be kept).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1