Added parquet format #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dim
commented
Jun 15, 2020
|
|
||
| private | ||
|
|
||
| def read_table |
There was a problem hiding this comment.
So the big downside of reading Parquet in Ruby that you MUST load the whole file into memory which is 💩. Nothing we can do about it, but something to keep in mind.
There was a problem hiding this comment.
as long as the input data is partitioned sensibly we should be ok
There was a problem hiding this comment.
Parquet sucks! Is there any reason the devs wouldn't update to add stream support? Is there a something about the implementation that requires it to be in memory?
There was a problem hiding this comment.
| msg = msg.to_parquet(@schema, **opts) if msg.respond_to?(:to_parquet) | ||
|
|
||
| res = @batch.push(msg) | ||
| flush_table if @batch.size >= @batch_size |
There was a problem hiding this comment.
On the writer side, we can work in batches. It's not ideal but at least it's a viable method.
jpmedforth
approved these changes
Jun 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.