Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrate from gogo/protobuf #31

Merged
merged 8 commits into from
Sep 10, 2020
Merged

migrate from gogo/protobuf #31

merged 8 commits into from
Sep 10, 2020

Conversation

mxmCherry
Copy link
Contributor

  • vendored trimmed down gogo/protobuf/io (as internal/pbio)
  • switched to golang/protobuf

internal/pbio/internal/test/extra.go Outdated Show resolved Hide resolved
internal/pbio/internal/test/thetest.proto Outdated Show resolved Hide resolved
internal/pbio/pbio.go Outdated Show resolved Hide resolved
internal/pbio/pbio_test.go Outdated Show resolved Hide resolved
@mxmCherry
Copy link
Contributor Author

@dim just in case: ext/parquet test fails for me:

• Failure [0.001 seconds]
Decoder
/home/mxmcherry/src/bsm/feedx/ext/parquet/decoder_test.go:16
  should decode [It]
  /home/mxmcherry/src/bsm/feedx/ext/parquet/decoder_test.go:37

  Expected
      <*parquet_test.mockStruct | 0xc00022a000>: {
          ID: 4,
          Bool: true,
          TinyInt: 0,
          SmallUint: 0,
          StdInt: 0,
          BigInt: 0,
          Float: 0,
          Double: 0,
          DateString: "03/01/09",
          ByteString: "0",
          Timestamp: 2009-03-01T02:00:00+02:00,
      }
  to equal
      <*parquet_test.mockStruct | 0xc00022aa10>: {
          ID: 4,
          Bool: true,
          TinyInt: 0,
          SmallUint: 0,
          StdInt: 0,
          BigInt: 0,
          Float: 0,
          Double: 0,
          DateString: "03/01/09",
          ByteString: "0",
          Timestamp: 2009-03-01T00:00:00+02:00,
      }

  /home/mxmcherry/src/bsm/feedx/ext/parquet/decoder_test.go:40

That's something to do with my +02:00 timezone; maybe expected value should be changed from time.Date(..., time.Local) to time.Unix(...)?

internal/pbio/go.mod Outdated Show resolved Hide resolved
ext/parquet/go.mod Outdated Show resolved Hide resolved
- switched to bsm/pbio
- switched to golang/protobuf
@mxmCherry mxmCherry requested a review from dim September 9, 2020 14:34
format.go Outdated Show resolved Hide resolved
format.go Outdated Show resolved Hide resolved
@mxmCherry mxmCherry requested a review from dim September 9, 2020 15:27
Copy link
Contributor Author

@mxmCherry mxmCherry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dim pushed both official protobuf + gogo protobuf handling (though no tests for gogo - maybe worth doing?)

format.go Outdated Show resolved Hide resolved
format.go Outdated Show resolved Hide resolved
Copy link
Member

@dim dim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will take a look at tests, 1s

format.go Outdated Show resolved Hide resolved
@dim
Copy link
Member

dim commented Sep 10, 2020

That's something to do with my +02:00 timezone; maybe expected value should be changed from time.Date(..., time.Local) to time.Unix(...)?

Hmm, yeah, timestamps in parquet should include TZ information, let me check and confirm, 1s

Copy link
Member

@dim dim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix tests, then 👍

@mxmCherry
Copy link
Contributor Author

@dim fixed, you can merge now (I cannot)

@dim dim merged commit e87ca2d into bsm:master Sep 10, 2020
@mxmCherry mxmCherry deleted the feature/migrate-from-gogo branch September 10, 2020 10:27
@mxmCherry
Copy link
Contributor Author

@dim and release, please (0.12.3 - no breaking changes)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants