-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
migrate from gogo/protobuf #31
Conversation
mxmCherry
commented
Sep 9, 2020
- vendored trimmed down gogo/protobuf/io (as internal/pbio)
- switched to golang/protobuf
@dim just in case: ext/parquet test fails for me:
That's something to do with my +02:00 timezone; maybe expected value should be changed from |
- switched to bsm/pbio - switched to golang/protobuf
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dim pushed both official protobuf + gogo protobuf handling (though no tests for gogo - maybe worth doing?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will take a look at tests, 1s
Hmm, yeah, timestamps in parquet should include TZ information, let me check and confirm, 1s |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix tests, then 👍
@dim fixed, you can merge now (I cannot) |
@dim and release, please (0.12.3 - no breaking changes) |