Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

compression: flate #32

Merged
merged 1 commit into from
Oct 28, 2020
Merged

compression: flate #32

merged 1 commit into from
Oct 28, 2020

Conversation

mxmCherry
Copy link
Contributor

There's no ruby (de)flate counterpart - it's slightly more tricky than Go:

  • need to implement own reader/writer
  • writer should be easy
  • but reader - not sure, maybe read in blocks (of length 0..MAXLEN) and deflate each block and then "proxy" each block (with smth like StringIO or so)?

dim
dim approved these changes Oct 27, 2020
View reviewed changes
compression.go Show resolved Hide resolved
compression.go Show resolved Hide resolved
@mxmCherry mxmCherry requested a review from dim October 27, 2020 14:07
@mxmCherry
Copy link
Contributor Author

@dim to merge

@dim dim merged commit a864ed9 into bsm:master Oct 28, 2020
@mxmCherry mxmCherry deleted the feature/flate-compression branch October 28, 2020 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dim dim dim approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mxmCherry @dim