Simpeler recurring pushers #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dim
force-pushed
the
feature/recurring
branch
from
e871f2a
to
37eeaf2
Compare
mxmCherry
reviewed
Nov 23, 2018
| iterator = relation.respond_to?(:find_each) ? :find_each : :each | ||
| relation.send(iterator) {|rec| stream.write(rec) } | ||
| iterator = enum.respond_to?(:find_each) ? :find_each : :each | ||
| enum.send(iterator) {|rec| stream.write(rec) } |
There was a problem hiding this comment.
There's no caching for def enum, it'll be resolved twice here.
I'd suggest to somehow cache self.enum value to be more consistent.
There was a problem hiding this comment.
it's cached, it's not using self.enum but the passed argument, I can make it nicer by renaming it though
mxmCherry
reviewed
Nov 23, 2018
mxmCherry
reviewed
Nov 23, 2018
|
@dim looks nice, though I've noticed that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@mxmCherry