Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add multi reader #49

Merged
merged 15 commits into from
Aug 25, 2023
Merged

add multi reader #49

merged 15 commits into from
Aug 25, 2023

Conversation

andyborn
Copy link
Contributor

@andyborn andyborn requested a review from dim August 21, 2023 15:43
dim
dim requested changes Aug 22, 2023
View reviewed changes
reader.go Show resolved Hide resolved
reader.go Show resolved Hide resolved
reader.go Outdated Show resolved Hide resolved
reader.go Outdated Show resolved Hide resolved
reader.go Outdated Show resolved Hide resolved
reader.go Outdated Show resolved Hide resolved
reader.go Outdated Show resolved Hide resolved
andyborn
andyborn commented Aug 22, 2023
View reviewed changes
reader.go Outdated Show resolved Hide resolved
@andyborn andyborn requested a review from dim August 22, 2023 10:03
dim
dim approved these changes Aug 22, 2023
View reviewed changes
Copy link
Member

@dim dim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mxmCherry to review this one too pls

reader.go Outdated Show resolved Hide resolved
@dim dim requested a review from mxmCherry August 22, 2023 10:14
andyborn
andyborn commented Aug 22, 2023
View reviewed changes
reader.go Outdated Show resolved Hide resolved
mxmCherry
mxmCherry reviewed Aug 22, 2023
View reviewed changes
Copy link
Contributor

@mxmCherry mxmCherry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will do a better take at this tomorrow morning.

reader.go Outdated Show resolved Hide resolved
mxmCherry
mxmCherry requested changes Aug 23, 2023
View reviewed changes
Copy link
Contributor

@mxmCherry mxmCherry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a bit lost in feedx.Reader.Read logic, suggest to handle non-zero n + EOF right in feedx.Reader.Read.

reader.go Outdated Show resolved Hide resolved
reader.go Outdated Show resolved Hide resolved
reader.go Show resolved Hide resolved
reader.go Outdated Show resolved Hide resolved
reader_test.go Outdated Show resolved Hide resolved
reader_test.go Outdated Show resolved Hide resolved
dim
dim reviewed Aug 24, 2023
View reviewed changes
Copy link
Member

@dim dim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me check this one more time

dim
dim reviewed Aug 24, 2023
View reviewed changes
reader.go Show resolved Hide resolved
dim
dim reviewed Aug 24, 2023
View reviewed changes
reader.go Outdated Show resolved Hide resolved
@andyborn andyborn requested a review from dim August 24, 2023 14:48
dim
dim reviewed Aug 24, 2023
View reviewed changes
reader.go Outdated Show resolved Hide resolved
dim
dim reviewed Aug 24, 2023
View reviewed changes
reader.go Show resolved Hide resolved
dim
dim reviewed Aug 25, 2023
View reviewed changes
reader.go Show resolved Hide resolved
reader.go Outdated Show resolved Hide resolved
reader.go Outdated Show resolved Hide resolved
dim
dim reviewed Aug 25, 2023
View reviewed changes
Copy link
Member

@dim dim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more tiny change

reader.go Outdated Show resolved Hide resolved
@dim
Copy link
Member

dim commented Aug 25, 2023

@andyborn separate PR, but you should update the google actions to use go1.20 + go1.21

@andyborn andyborn merged commit 467ee0e into bsm:main Aug 25, 2023
7 checks passed
@mxmCherry mxmCherry mentioned this pull request May 21, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dim dim dim approved these changes

@mxmCherry mxmCherry mxmCherry approved these changes

@jpmedforth jpmedforth Awaiting requested review from jpmedforth

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andyborn @dim @mxmCherry