-
Notifications
You must be signed in to change notification settings - Fork 2
[FEATURE] implement getFiatExchangeRate on WalletServices #618
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE] implement getFiatExchangeRate on WalletServices #618
Conversation
Manual Testsℹ️ Remember to ask team members to perform manual tests and to assign |
Manual Tests💚 Manual testing by @cain4chain resulted in success. |
160290f
to
8166b99
Compare
8166b99
to
3f132b5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR implements the getFiatExchangeRate
method on WalletServices to support fiat currency exchange rate conversion functionality. The implementation allows users to convert between different fiat currencies using configurable exchange rates.
Key changes:
- Replaced panic placeholder with actual implementation of
FiatExchangeRate
method - Added comprehensive unit tests covering various conversion scenarios and edge cases
- Created documentation and example code demonstrating the new functionality
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
File | Description |
---|---|
pkg/services/services.go | Implements the FiatExchangeRate method with currency conversion logic |
pkg/services/services_fiat_exchange_test.go | Adds comprehensive test coverage for the new method |
examples/services_examples/fiat_exhange_rate/fiat_exchange_rate.go | Provides example implementation demonstrating usage |
examples/services_examples/fiat_exhange_rate/fiat_exchange_rate.md | Documentation explaining the feature and usage |
examples/services_examples/nlock_time_is_final/nlock_time_is_final.go | Removes inline documentation comment |
examples/services_examples/nlock_time_is_final/nlock_time_is_final.md | Adds separate documentation file |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
examples/services_examples/fiat_exhange_rate/fiat_exchange_rate.md
Outdated
Show resolved
Hide resolved
examples/services_examples/fiat_exhange_rate/fiat_exchange_rate.md
Outdated
Show resolved
Hide resolved
428c120
to
03e9c78
Compare
03e9c78
to
2b0c62f
Compare
|
Description of Changes
Provide a brief description of the changes you've made.
Linked Issues / Tickets
Reference any related issues or tickets, e.g. "Closes #123".
Testing Procedure
Describe the tests you've added or any testing steps you've taken.
Checklist: