Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 🐛 font format could be without qoutation #217

Merged
merged 1 commit into from
Dec 2, 2021
Merged

fix: 🐛 font format could be without qoutation #217

merged 1 commit into from
Dec 2, 2021

Conversation

dews
Copy link
Contributor

@dews dews commented Nov 26, 2021

Description

Use document.styleSheets[index].cssRules[0].cssText to get font-face, (index is dependent on styleSheets load order)
On windows,

@font-face { font-family: "Material Design Icons"; src: url("https://cdn.jsdelivr.net/npm/@mdi/font@6.5.95/fonts/materialdesignicons-webfont.woff2?v=6.5.95") format("woff2"), url("https://cdn.jsdelivr.net/npm/@mdi/font@6.5.95/fonts/materialdesignicons-webfont.ttf?v=6.5.95") format("truetype"); font-weight: normal; font-style: normal; }

But when using Safari on iOS or Safari/Chrome on iPhone,

@font-face { font-family: "Material Design Icons"; src: url(https://cdn.jsdelivr.net/npm/@mdi/font@6.5.95/fonts/materialdesignicons-webfont.woff2?v=6.5.95) format(woff2), url(https://cdn.jsdelivr.net/npm/@mdi/font@6.5.95/fonts/materialdesignicons-webfont.ttf?v=6.5.95) format(truetype); font-weight: normal; font-style: normal; }

From W3C, https://drafts.csswg.org/css-fonts/#font-face-src-parsing, example22 you can see the format is unquoted.

Codepen, https://codepen.io/dews/pen/oNeKjLd

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Enhancement (changes that improvement of current feature or performance)
  • Refactoring (changes that neither fixes a bug nor adds a feature)
  • Test Case (changes that add missing tests or correct existing tests)
  • Code style optimization (changes that do not affect the meaning of the code)
  • Docs (changes that only update documentation)
  • Chore (changes that don't modify src or test files)

Self Check before Merge

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@biiibooo
Copy link
Contributor

biiibooo bot commented Nov 26, 2021

👋 @dews

💖 Thanks for opening this pull request! 💖

Please follow the contributing guidelines. And we use semantic commit messages to streamline the release process.

Examples of commit messages with semantic prefixes:

  • fix: don't overwrite prevent_default if default wasn't prevented
  • feat: add graph.scale() method
  • docs: graph.getShortestPath is now available

Things that will help get your PR across the finish line:

  • Follow the TypeScript coding style.
  • Run npm run lint locally to catch formatting errors earlier.
  • Document any user-facing changes you've made.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@codecov
Copy link

codecov bot commented Nov 26, 2021

Codecov Report

Merging #217 (37f04cf) into master (c51da3a) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #217   +/-   ##
=======================================
  Coverage   76.97%   76.97%           
=======================================
  Files          10       10           
  Lines         608      608           
  Branches      120      120           
=======================================
  Hits          468      468           
  Misses         72       72           
  Partials       68       68           
Impacted Files Coverage Δ
src/embedResources.ts 88.37% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6704052...37f04cf. Read the comment docs.

@bubkoo bubkoo merged commit 2a96149 into bubkoo:master Dec 2, 2021
@biiibooo
Copy link
Contributor

biiibooo bot commented Dec 2, 2021

👋 @dews Congrats on merging your first pull request! 🎉🎉🎉

github-actions bot pushed a commit that referenced this pull request Aug 11, 2022
# [1.10.0](v1.9.0...v1.10.0) (2022-08-11)

### Bug Fixes

* 🐛 cloneCSSStyle: copy transformOriginProp ([#297](#297)) ([76b978a](76b978a))
* 🐛 font format could be without qoutation ([#217](#217)) ([2a96149](2a96149))
* 🐛 set selected attribute on option to draw it ([#280](#280)) ([caf97c8](caf97c8))
* 🐛 text breaks on the last word ([#270](#270)) ([062c98a](062c98a))
* test specs ([c7a664e](c7a664e))

### Features

* ✨ add 'fetchRequestInit' option ([#210](#210)) ([c51da3a](c51da3a))
* ✨ added includeQueryParams flag ([#260](#260)) ([259d71e](259d71e))
@biiibooo
Copy link
Contributor

biiibooo bot commented Aug 11, 2022

🎉 This PR is included in version 1.10.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@biiibooo biiibooo bot added the released label Aug 11, 2022
@dews dews deleted the fix-ios branch September 13, 2022 09:28
istaiti pushed a commit to inscreen/html-to-image that referenced this pull request Feb 7, 2023
* 🐛 cloneCSSStyle: copy transformOriginProp ([bubkoo#297](bubkoo#297)) ([76b978a](bubkoo@76b978a))
* 🐛 font format could be without qoutation ([bubkoo#217](bubkoo#217)) ([2a96149](bubkoo@2a96149))
* 🐛 set selected attribute on option to draw it ([bubkoo#280](bubkoo#280)) ([caf97c8](bubkoo@caf97c8))
* 🐛 text breaks on the last word ([bubkoo#270](bubkoo#270)) ([062c98a](bubkoo@062c98a))
* test specs ([c7a664e](bubkoo@c7a664e))

* ✨ add 'fetchRequestInit' option ([bubkoo#210](bubkoo#210)) ([c51da3a](bubkoo@c51da3a))
* ✨ added includeQueryParams flag ([bubkoo#260](bubkoo#260)) ([259d71e](bubkoo@259d71e))
istaiti pushed a commit to inscreen/html-to-image that referenced this pull request Feb 7, 2023
* 🐛 cloneCSSStyle: copy transformOriginProp ([bubkoo#297](bubkoo#297)) ([76b978a](bubkoo@76b978a))
* 🐛 font format could be without qoutation ([bubkoo#217](bubkoo#217)) ([2a96149](bubkoo@2a96149))
* 🐛 set selected attribute on option to draw it ([bubkoo#280](bubkoo#280)) ([caf97c8](bubkoo@caf97c8))
* 🐛 text breaks on the last word ([bubkoo#270](bubkoo#270)) ([062c98a](bubkoo@062c98a))
* test specs ([c7a664e](bubkoo@c7a664e))

* ✨ add 'fetchRequestInit' option ([bubkoo#210](bubkoo#210)) ([c51da3a](bubkoo@c51da3a))
* ✨ added includeQueryParams flag ([bubkoo#260](bubkoo#260)) ([259d71e](bubkoo@259d71e))
istaiti pushed a commit to inscreen/html-to-image that referenced this pull request Feb 7, 2023
* 🐛 cloneCSSStyle: copy transformOriginProp ([bubkoo#297](bubkoo#297)) ([76b978a](bubkoo@76b978a))
* 🐛 font format could be without qoutation ([bubkoo#217](bubkoo#217)) ([2a96149](bubkoo@2a96149))
* 🐛 set selected attribute on option to draw it ([bubkoo#280](bubkoo#280)) ([caf97c8](bubkoo@caf97c8))
* 🐛 text breaks on the last word ([bubkoo#270](bubkoo#270)) ([062c98a](bubkoo@062c98a))
* test specs ([c7a664e](bubkoo@c7a664e))

* ✨ add 'fetchRequestInit' option ([bubkoo#210](bubkoo#210)) ([c51da3a](bubkoo@c51da3a))
* ✨ added includeQueryParams flag ([bubkoo#260](bubkoo#260)) ([259d71e](bubkoo@259d71e))
istaiti pushed a commit to inscreen/html-to-image that referenced this pull request Feb 7, 2023
* 🐛 cloneCSSStyle: copy transformOriginProp ([bubkoo#297](bubkoo#297)) ([76b978a](bubkoo@76b978a))
* 🐛 font format could be without qoutation ([bubkoo#217](bubkoo#217)) ([2a96149](bubkoo@2a96149))
* 🐛 set selected attribute on option to draw it ([bubkoo#280](bubkoo#280)) ([caf97c8](bubkoo@caf97c8))
* 🐛 text breaks on the last word ([bubkoo#270](bubkoo#270)) ([062c98a](bubkoo@062c98a))
* test specs ([c7a664e](bubkoo@c7a664e))

* ✨ add 'fetchRequestInit' option ([bubkoo#210](bubkoo#210)) ([c51da3a](bubkoo@c51da3a))
* ✨ added includeQueryParams flag ([bubkoo#260](bubkoo#260)) ([259d71e](bubkoo@259d71e))
istaiti pushed a commit to inscreen/html-to-image that referenced this pull request Feb 7, 2023
* 🐛 cloneCSSStyle: copy transformOriginProp ([bubkoo#297](bubkoo#297)) ([76b978a](bubkoo@76b978a))
* 🐛 font format could be without qoutation ([bubkoo#217](bubkoo#217)) ([2a96149](bubkoo@2a96149))
* 🐛 set selected attribute on option to draw it ([bubkoo#280](bubkoo#280)) ([caf97c8](bubkoo@caf97c8))
* 🐛 text breaks on the last word ([bubkoo#270](bubkoo#270)) ([062c98a](bubkoo@062c98a))
* test specs ([c7a664e](bubkoo@c7a664e))

* ✨ add 'fetchRequestInit' option ([bubkoo#210](bubkoo#210)) ([c51da3a](bubkoo@c51da3a))
* ✨ added includeQueryParams flag ([bubkoo#260](bubkoo#260)) ([259d71e](bubkoo@259d71e))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants