-
Notifications
You must be signed in to change notification settings - Fork 542
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: 🐛 font format could be without qoutation #217
Conversation
👋 @dews 💖 Thanks for opening this pull request! 💖 Please follow the contributing guidelines. And we use semantic commit messages to streamline the release process. Examples of commit messages with semantic prefixes:
Things that will help get your PR across the finish line:
We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can. |
Codecov Report
@@ Coverage Diff @@
## master #217 +/- ##
=======================================
Coverage 76.97% 76.97%
=======================================
Files 10 10
Lines 608 608
Branches 120 120
=======================================
Hits 468 468
Misses 72 72
Partials 68 68
Continue to review full report at Codecov.
|
👋 @dews Congrats on merging your first pull request! 🎉🎉🎉 |
# [1.10.0](v1.9.0...v1.10.0) (2022-08-11) ### Bug Fixes * 🐛 cloneCSSStyle: copy transformOriginProp ([#297](#297)) ([76b978a](76b978a)) * 🐛 font format could be without qoutation ([#217](#217)) ([2a96149](2a96149)) * 🐛 set selected attribute on option to draw it ([#280](#280)) ([caf97c8](caf97c8)) * 🐛 text breaks on the last word ([#270](#270)) ([062c98a](062c98a)) * test specs ([c7a664e](c7a664e)) ### Features * ✨ add 'fetchRequestInit' option ([#210](#210)) ([c51da3a](c51da3a)) * ✨ added includeQueryParams flag ([#260](#260)) ([259d71e](259d71e))
🎉 This PR is included in version 1.10.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
* 🐛 cloneCSSStyle: copy transformOriginProp ([bubkoo#297](bubkoo#297)) ([76b978a](bubkoo@76b978a)) * 🐛 font format could be without qoutation ([bubkoo#217](bubkoo#217)) ([2a96149](bubkoo@2a96149)) * 🐛 set selected attribute on option to draw it ([bubkoo#280](bubkoo#280)) ([caf97c8](bubkoo@caf97c8)) * 🐛 text breaks on the last word ([bubkoo#270](bubkoo#270)) ([062c98a](bubkoo@062c98a)) * test specs ([c7a664e](bubkoo@c7a664e)) * ✨ add 'fetchRequestInit' option ([bubkoo#210](bubkoo#210)) ([c51da3a](bubkoo@c51da3a)) * ✨ added includeQueryParams flag ([bubkoo#260](bubkoo#260)) ([259d71e](bubkoo@259d71e))
* 🐛 cloneCSSStyle: copy transformOriginProp ([bubkoo#297](bubkoo#297)) ([76b978a](bubkoo@76b978a)) * 🐛 font format could be without qoutation ([bubkoo#217](bubkoo#217)) ([2a96149](bubkoo@2a96149)) * 🐛 set selected attribute on option to draw it ([bubkoo#280](bubkoo#280)) ([caf97c8](bubkoo@caf97c8)) * 🐛 text breaks on the last word ([bubkoo#270](bubkoo#270)) ([062c98a](bubkoo@062c98a)) * test specs ([c7a664e](bubkoo@c7a664e)) * ✨ add 'fetchRequestInit' option ([bubkoo#210](bubkoo#210)) ([c51da3a](bubkoo@c51da3a)) * ✨ added includeQueryParams flag ([bubkoo#260](bubkoo#260)) ([259d71e](bubkoo@259d71e))
* 🐛 cloneCSSStyle: copy transformOriginProp ([bubkoo#297](bubkoo#297)) ([76b978a](bubkoo@76b978a)) * 🐛 font format could be without qoutation ([bubkoo#217](bubkoo#217)) ([2a96149](bubkoo@2a96149)) * 🐛 set selected attribute on option to draw it ([bubkoo#280](bubkoo#280)) ([caf97c8](bubkoo@caf97c8)) * 🐛 text breaks on the last word ([bubkoo#270](bubkoo#270)) ([062c98a](bubkoo@062c98a)) * test specs ([c7a664e](bubkoo@c7a664e)) * ✨ add 'fetchRequestInit' option ([bubkoo#210](bubkoo#210)) ([c51da3a](bubkoo@c51da3a)) * ✨ added includeQueryParams flag ([bubkoo#260](bubkoo#260)) ([259d71e](bubkoo@259d71e))
* 🐛 cloneCSSStyle: copy transformOriginProp ([bubkoo#297](bubkoo#297)) ([76b978a](bubkoo@76b978a)) * 🐛 font format could be without qoutation ([bubkoo#217](bubkoo#217)) ([2a96149](bubkoo@2a96149)) * 🐛 set selected attribute on option to draw it ([bubkoo#280](bubkoo#280)) ([caf97c8](bubkoo@caf97c8)) * 🐛 text breaks on the last word ([bubkoo#270](bubkoo#270)) ([062c98a](bubkoo@062c98a)) * test specs ([c7a664e](bubkoo@c7a664e)) * ✨ add 'fetchRequestInit' option ([bubkoo#210](bubkoo#210)) ([c51da3a](bubkoo@c51da3a)) * ✨ added includeQueryParams flag ([bubkoo#260](bubkoo#260)) ([259d71e](bubkoo@259d71e))
* 🐛 cloneCSSStyle: copy transformOriginProp ([bubkoo#297](bubkoo#297)) ([76b978a](bubkoo@76b978a)) * 🐛 font format could be without qoutation ([bubkoo#217](bubkoo#217)) ([2a96149](bubkoo@2a96149)) * 🐛 set selected attribute on option to draw it ([bubkoo#280](bubkoo#280)) ([caf97c8](bubkoo@caf97c8)) * 🐛 text breaks on the last word ([bubkoo#270](bubkoo#270)) ([062c98a](bubkoo@062c98a)) * test specs ([c7a664e](bubkoo@c7a664e)) * ✨ add 'fetchRequestInit' option ([bubkoo#210](bubkoo#210)) ([c51da3a](bubkoo@c51da3a)) * ✨ added includeQueryParams flag ([bubkoo#260](bubkoo#260)) ([259d71e](bubkoo@259d71e))
Description
Use
document.styleSheets[index].cssRules[0].cssText
to get font-face, (index is dependent on styleSheets load order)On windows,
But when using Safari on iOS or Safari/Chrome on iPhone,
From W3C, https://drafts.csswg.org/css-fonts/#font-face-src-parsing, example22 you can see the format is unquoted.
Codepen, https://codepen.io/dews/pen/oNeKjLd
Motivation and Context
Types of changes
Self Check before Merge