feat: ✨ added includeQueryParams flag #260

dragos199993 · 2022-03-14T08:18:23Z

Description

Motivation and Context

Gives the option to use the entire URL in order to have a cache key that includes query parameters.
Fixes: #259

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)
Enhancement (changes that improvement of current feature or performance)
Refactoring (changes that neither fixes a bug nor adds a feature)
Test Case (changes that add missing tests or correct existing tests)
Code style optimization (changes that do not affect the meaning of the code)
Docs (changes that only update documentation)
Chore (changes that don't modify src or test files)

Self Check before Merge

My code follows the code style of this project.
My change requires a change to the documentation.
I have updated the documentation accordingly.
I have read the CONTRIBUTING document.
I have added tests to cover my changes.
All new and existing tests passed.

biiibooo · 2022-03-14T08:18:42Z

👋 @dragos199993

💖 Thanks for opening this pull request! 💖

Please follow the contributing guidelines. And we use semantic commit messages to streamline the release process.

Examples of commit messages with semantic prefixes:

fix: don't overwrite prevent_default if default wasn't prevented
feat: add graph.scale() method
docs: graph.getShortestPath is now available

Things that will help get your PR across the finish line:

Follow the TypeScript coding style.
Run npm run lint locally to catch formatting errors earlier.
Document any user-facing changes you've made.
Include tests when adding/changing behavior.
Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

dragos199993 · 2022-03-14T08:20:14Z

src/embedWebFonts.ts

-                          : sheet.hasOwnProperty('cssRules').length,
+                          : // eslint-disable-next-line @typescript-eslint/ban-ts-comment
+                            // @ts-ignore
+                            sheet.hasOwnProperty('cssRules').length,


Is there any other solution to this? hasOwnProperty returns boolean so .length is not a valid method

can we use ('cssRules' in sheet) for this?

biiibooo · 2022-04-04T01:41:45Z

Hiya!
This PR has gone quiet. Spooky quiet. 👻
We get a lot of PRs, so we currently close PRs after 60 days of inactivity. It’s been at least 20 days since the last update here. If we missed this PR or if you want to keep it open, please reply here. You can also add the label "not-stale" to keep this PR open!
Thanks for being a part of the Antv community! 💪💯

dragos199993 · 2022-04-04T05:38:07Z

This PR is still valid

MatanYemini · 2022-04-20T11:50:07Z

Any reason why not move this forward?

osplm · 2022-04-21T14:56:51Z

Was about to open a PR exactly for this problem. Would be nice to merge this 👍

osplm · 2022-04-21T14:59:07Z

src/getBlobFromURL.ts

@@ -10,10 +10,14 @@ const cache: {
  [url: string]: Promise<Metadata>
 } = {}

-function getCacheKey(url: string) {
+function getCacheKey(url: string, includeQueryParams: boolean | undefined) {
  let key = url.replace(/\?.*/, '')


Nitpick: No need to replace if we will reassign the full url after so we should replace only if it's not to includeQueyParams right?

ortonomy · 2022-05-05T01:19:53Z

Really need this. This lib is incompatible with libraries like next.js which caches images and retrieves them like /next/_image?url=..... -- which appear to html-to-image as the same URL currently

RodrigoTomeES · 2022-05-17T20:22:17Z

Hi, any update about this?

biiibooo · 2022-06-07T01:47:15Z

Hiya!
This PR has gone quiet. Spooky quiet. 👻
We get a lot of PRs, so we currently close PRs after 60 days of inactivity. It’s been at least 20 days since the last update here. If we missed this PR or if you want to keep it open, please reply here. You can also add the label "not-stale" to keep this PR open!
Thanks for being a part of the Antv community! 💪💯

ortonomy · 2022-06-13T07:04:17Z

For anyone else looking for a solution to this, at least with next.js, I found out that next.js has a built in proxy that they call 'redirects' -- I was able to make it look like the image was coming from local, and with a different URL each time by not using next.js's built in image lib and proxying requests so they were 'secure' via the server: https://nextjs.org/docs/api-reference/next.config.js/redirects

biiibooo · 2022-07-04T02:09:06Z

Hiya!
This PR has gone quiet. Spooky quiet. 👻
We get a lot of PRs, so we currently close PRs after 60 days of inactivity. It’s been at least 20 days since the last update here. If we missed this PR or if you want to keep it open, please reply here. You can also add the label "not-stale" to keep this PR open!
Thanks for being a part of the Antv community! 💪💯

RodrigoTomeES · 2022-07-04T05:34:26Z

There is any plan to merge this PR?

biiibooo · 2022-07-25T02:01:14Z

Hiya!
This PR has gone quiet. Spooky quiet. 👻
We get a lot of PRs, so we currently close PRs after 60 days of inactivity. It’s been at least 20 days since the last update here. If we missed this PR or if you want to keep it open, please reply here. You can also add the label "not-stale" to keep this PR open!
Thanks for being a part of the Antv community! 💪💯

biiibooo · 2022-08-10T07:05:02Z

👋 @dragos199993 Congrats on merging your first pull request! 🎉🎉🎉

# [1.10.0](v1.9.0...v1.10.0) (2022-08-11) ### Bug Fixes * 🐛 cloneCSSStyle: copy transformOriginProp ([#297](#297)) ([76b978a](76b978a)) * 🐛 font format could be without qoutation ([#217](#217)) ([2a96149](2a96149)) * 🐛 set selected attribute on option to draw it ([#280](#280)) ([caf97c8](caf97c8)) * 🐛 text breaks on the last word ([#270](#270)) ([062c98a](062c98a)) * test specs ([c7a664e](c7a664e)) ### Features * ✨ add 'fetchRequestInit' option ([#210](#210)) ([c51da3a](c51da3a)) * ✨ added includeQueryParams flag ([#260](#260)) ([259d71e](259d71e))

biiibooo · 2022-08-11T09:06:25Z

🎉 This PR is included in version 1.10.0 🎉

The release is available on:

Your semantic-release bot 📦🚀