Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Group block sketches #2

Open
karmatosed opened this issue Jan 4, 2020 · 3 comments
Open

Group block sketches #2

karmatosed opened this issue Jan 4, 2020 · 3 comments

Comments

@karmatosed
Copy link
Collaborator

@karmatosed karmatosed commented Jan 4, 2020

I began to think how the group block could work. I think staying simple makes sense here. A few points:

  1. Use placeholder to pick group: a simple step that other blocks use of the placeholder being a way to select (see navigation block ).
  2. The sidebar in v1 probably won't be used but could contain presentation (secondary) options that don't matter but could be nice. Worth noting it's important to not fill this up with multiple inputs the same like switches.

For the start of this I am keeping it super rough:

image

This block just displays the cover image and name of the group. I would like us to consider what the use is, for example, would we want to show invitations to join or maybe a click-through, or is it to also go as far as showing group activity? Maybe there are 2 blocks here, one for group profile and one for group activity?

@renatonascalves

This comment has been minimized.

Copy link
Member

@renatonascalves renatonascalves commented Jan 4, 2020

That's nice! A few thoughts:

  • At the moment, both the users and the groups components have support to cover and profile/avatar images/attachments. I'd like us to make something that would accomodate both or any of them, as there are communities using one or the other. Both of them could use placeholders (as it is already used in the normal theme), but visually, it'd be good if they could "match" on the block.

  • Having the cover or profile image and the group title, linking to the group itself seems like a first pass. However, now we are going to enter in a place of necessities. Communities necessity. Some would like to have the total number of members in the group in the block, or the total number of activities, or adding the group title and also the group moderator with their information, etc.

I'm not saying we should add those things. Only that the block should be flexible enough, visually, that adding those information (I presume this will be a dynamic block), will not be much of a hassle.

  • One last note about the picker. I wonder if it should be a search input though. For communities with hundreds of groups, that would be easier and more performant.

--

Now to your questions.

would we want to show invitations to join or maybe a click-through,

This seems like a good idea. Having a checkbox in the sidebar to hide/show this would be ideal.

or is it to also go as far as showing group activity?

I'd think not. But we can see requests to show a "preview", kind of like the recent 10 activities, or the latest 10 forum topics of a group, etc. I however don't know the demand for this, so I'd label it as nice-to-have.

Maybe there are 2 blocks here, one for group profile and one for group activity?

I'm not sure if it deserves a second block. Doing in a way that it inserts into the group block and is left out without loss to the layout, I could see something similar to the invitation idea you brought it up.

Meaning, I can click an option in the sidebar and have a feed of activitiy or group forum topics. I know the idea is not to overflow the sidebar with settings, but I don't see the need for a second block for something that would be better served together with the main block.

Anyway, my suggestion of an approach would be to have a block like a transformer, where one could put or remove part of blocks in without disrupting everything.
:)

@imath

This comment has been minimized.

Copy link
Contributor

@imath imath commented Jan 11, 2020

Thanks @karmatosed for your work on this and thanks @renatonascalves for your feedback.

Here are my thoughts:

  • I agree with Renato about the dropdown control we should probably use an autocomplete control. I can imagine considering the block will be available within the editor, admins will be able to list all ! hidden groups of the community site.
  • for a first version let’s keep it simple : Group Name linked to the group’s page, Group Description, avatar, cover.
  • the settings sidebar can be used as Tammie suggested to hide/show all properties of my previous point except the group name.
  • in the future: I see a great interest in displaying the number of group members and action buttons like Visit or Join.

I believe « Group Activities » is another block 😉

imath added a commit that referenced this issue Feb 11, 2020
It is pretty much the same than the BP Member block...
Add an objectStatus property to the BPAutocompleter component and use it from the BP Block to only fetch public groups. This choice might need to be discussed...

See #2
imath added a commit that referenced this issue Feb 11, 2020
@imath

This comment has been minimized.

Copy link
Contributor

@imath imath commented Feb 11, 2020

As @renatonascalves requested, I've used a PR instead of directly committing. Thanks in advance for your feedbacks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.