-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Group block sketches #2
Comments
That's nice! A few thoughts:
I'm not saying we should add those things. Only that the block should be flexible enough, visually, that adding those information (I presume this will be a dynamic block), will not be much of a hassle.
-- Now to your questions.
This seems like a good idea. Having a checkbox in the sidebar to hide/show this would be ideal.
I'd think not. But we can see requests to show a "preview", kind of like the recent 10 activities, or the latest 10 forum topics of a group, etc. I however don't know the demand for this, so I'd label it as nice-to-have.
I'm not sure if it deserves a second block. Doing in a way that it inserts into the group block and is left out without loss to the layout, I could see something similar to the invitation idea you brought it up. Meaning, I can click an option in the sidebar and have a feed of activitiy or group forum topics. I know the idea is not to overflow the sidebar with settings, but I don't see the need for a second block for something that would be better served together with the main block. Anyway, my suggestion of an approach would be to have a block like a transformer, where one could put or remove part of blocks in without disrupting everything. |
Thanks @karmatosed for your work on this and thanks @renatonascalves for your feedback. Here are my thoughts:
I believe « Group Activities » is another block 😉 |
It is pretty much the same than the BP Member block... Add an objectStatus property to the BPAutocompleter component and use it from the BP Block to only fetch public groups. This choice might need to be discussed... See #2
As @renatonascalves requested, I've used a PR instead of directly committing. Thanks in advance for your feedbacks. |
Closing this as the block has been merged into BP Core |
I began to think how the group block could work. I think staying simple makes sense here. A few points:
For the start of this I am keeping it super rough:
This block just displays the cover image and name of the group. I would like us to consider what the use is, for example, would we want to show invitations to join or maybe a click-through, or is it to also go as far as showing group activity? Maybe there are 2 blocks here, one for group profile and one for group activity?
The text was updated successfully, but these errors were encountered: