Fix #35 #37
Merged
Fix #35 #37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- type assertion is necessary to make TS 2.5 happy
1 similar comment
|
So they did fix the #24 ? |
buehler
requested changes
Oct 28, 2017
| import DefaultAlias, { Specifier1 } from 'namedImport'; | ||
| import { default as __DefaultAlias, Specifier1 as __Specifier1 } from 'namedImport'; | ||
| import __DefaultAlias, { Specifier1 as __Specifier1 } from 'namedImport'; | ||
| import * as __namespaceImport from 'namespace'; |
There was a problem hiding this comment.
just a cosmetical thing: please enter a new line :-)
| "lodash": "^4.17.4", | ||
| "tslib": "^1.7.1", | ||
| "typescript": "2.4.2" | ||
| "typescript": "^2.5.3" |
There was a problem hiding this comment.
Question: so they did fix the problem with the typed declaration in #24 ?
buehler
previously approved these changes
Oct 28, 2017
buehler
dismissed
their stale review
will upgrade the windows testing part anyway
|
@buehler Thanks, I just looked at your review questions, but seems like it's all resolved and merged. Cheers! |
|
Yea I did not know appveyor, so I just improved it after the merge ;-) I'm going to add appveyor to typescript hero as well. This will be a good thing :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrading to TypeScript 2.5 fixes the issue where identifiers starting with two underscores would have a third added. All other tests still pass.
Fixes #35 and buehler/typescript-hero#320.