Remove apiKey property from bugsnag plugin extension #210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fractalwrench
changed the title
fractalwrench
force-pushed
the
v5-remove-api-key
branch
2 times, most recently
from
2b4ed45
to
95d6850
Compare
imjoehaines
approved these changes
Jul 2, 2020
src/main/groovy/com/bugsnag/android/gradle/BugsnagVariantOutputTask.groovy
Outdated
Show resolved
Hide resolved
fractalwrench
force-pushed
the
v5-remove-api-key
branch
from
95d6850
to
1b61e51
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Removes the deprecated apiKey property from the
BugsnagPluginExtensionclass. This means that users must specify their API key in the AndroidManifest rather than the plugin extension, which led to confusion in the past.Tests
Relied on existing E2E test coverage. Updated
fail_on_upload.featureto allow specifying an empty API key in one scenario.