[PLAT-8308] Add isStarted to notifiers #1737
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
| Minified | Minfied + Gzipped | |
|---|---|---|
| Before | 42.43 kB |
12.98 kB |
| After | 42.48 kB |
12.99 kB |
| ± | +45 bytes |
+14 bytes |
code coverage diff
| Ok | File | Lines | Branches | Functions | Statements |
|---|---|---|---|---|---|
| ✅ | /home/runner/work/bugsnag-js/bugsnag-js/packages/browser/src/notifier.js | 96.49% (+0.06%) |
64.29% (+0%) |
100% (+0%) |
93.44% (+0.11%) |
| ✅ | /home/runner/work/bugsnag-js/bugsnag-js/packages/delivery-electron/delivery.js | 97.53% (+0%) |
89.66% (+3.45%) |
78.26% (+0%) |
94.44% (+0%) |
| ✅ | /home/runner/work/bugsnag-js/bugsnag-js/packages/delivery-electron/payload-loop.js | 87.8% (+0%) |
78.57% (+7.14%) |
85.71% (+0%) |
86.05% (+0%) |
| ✅ | /home/runner/work/bugsnag-js/bugsnag-js/packages/electron-filestore/filestore.js | 83.33% (+3.84%) |
52.38% (+0%) |
88.46% (+3.84%) |
83.33% (+3.84%) |
| ✅ | /home/runner/work/bugsnag-js/bugsnag-js/packages/electron/src/id.js | 100% (+100%) |
100% (+0%) |
100% (+0%) |
100% (+100%) |
| ✅ | /home/runner/work/bugsnag-js/bugsnag-js/packages/electron/src/notifier.js | 69.7% (+22.82%) |
68.75% (+37.5%) |
50% (+30%) |
64.86% (+20.42%) |
| ✅ | /home/runner/work/bugsnag-js/bugsnag-js/packages/electron/src/client/main.js | 93.75% (+40.62%) |
66.67% (+50%) |
50% (+0%) |
90.91% (+39.39%) |
| ✅ | /home/runner/work/bugsnag-js/bugsnag-js/packages/electron/src/client/renderer.js | 78.13% (+43.75%) |
37.5% (+37.5%) |
30% (+30%) |
72.22% (+41.66%) |
| ✅ | /home/runner/work/bugsnag-js/bugsnag-js/packages/electron/src/config/common.js | 75% (+10%) |
80% (+0%) |
72.73% (+18.18%) |
76.92% (+7.69%) |
| ✅ | /home/runner/work/bugsnag-js/bugsnag-js/packages/electron/src/config/main.js | 79.17% (+37.5%) |
30% (+10%) |
57.14% (+50%) |
76% (+36%) |
| ✅ | /home/runner/work/bugsnag-js/bugsnag-js/packages/electron/src/config/renderer.js | 61.76% (+38.23%) |
35.71% (+35.71%) |
66.67% (+58.34%) |
60% (+37.14%) |
| 🔴 | /home/runner/work/bugsnag-js/bugsnag-js/packages/node/src/notifier.js | 92.45% (-1.78%) |
60% (+0%) |
66.67% (-13.33%) |
87.72% (-1.57%) |
| ✅ | /home/runner/work/bugsnag-js/bugsnag-js/packages/plugin-electron-app/app.js | 98.41% (+0%) |
90% (+3.33%) |
100% (+0%) |
98.51% (+0%) |
| ✅ | /home/runner/work/bugsnag-js/bugsnag-js/packages/plugin-electron-deliver-minidumps/deliver-minidumps.js | 57.38% (+6.56%) |
43.75% (+0%) |
50% (+16.67%) |
59.09% (+7.57%) |
| ✅ | /home/runner/work/bugsnag-js/bugsnag-js/packages/plugin-electron-ipc/electron-ipc.js | 70.83% (+70.83%) |
0% (+0%) |
50% (+50%) |
68% (+68%) |
| ✅ | /home/runner/work/bugsnag-js/bugsnag-js/packages/plugin-electron-net-breadcrumbs/net-breadcrumbs.js | 57.14% (+47.62%) |
50% (+50%) |
57.14% (+57.14%) |
59.09% (+50%) |
| ✅ | /home/runner/work/bugsnag-js/bugsnag-js/packages/plugin-electron-network-status/network-status.js | 100% (+0%) |
100% (+33.33%) |
100% (+0%) |
100% (+0%) |
| ✅ | /home/runner/work/bugsnag-js/bugsnag-js/packages/plugin-electron-process-info/procinfo.js | 93.33% (+0%) |
77.78% (+5.56%) |
100% (+0%) |
93.75% (+0%) |
| ✅ | /home/runner/work/bugsnag-js/bugsnag-js/packages/react-native/src/notifier.js | 73.17% (+0.33%) |
65.79% (+0%) |
64.29% (+2.75%) |
72.22% (+0.31%) |
Total:
| Lines | Branches | Functions | Statements |
|---|---|---|---|
| 87.32%(+2.29%) | 75.36%(+1.43%) | 86.77%(+2.67%) | 86.23%(+2.17%) |
gingerbenw
force-pushed
the
plat-8308-is-started
branch
from
dfdaeb1
to
3d6ca0e
Compare
gingerbenw
force-pushed
the
plat-8308-is-started
branch
from
3d6ca0e
to
6c7c2c0
Compare
gareththackeray
approved these changes
May 17, 2022
imjoehaines
reviewed
May 19, 2022
There was a problem hiding this comment.
The code changes LGTM
I don't think we need both packages/react-native/src/test/notifier.test.ts and packages/react-native/test/index.test.ts though, since they're both testing the same thing
I'd suggest getting rid of packages/react-native/src/test/notifier.test.ts as the other test has a lot more cleanup so there's less likely for issues after calling start multiple times
gingerbenw
force-pushed
the
plat-8308-is-started
branch
from
1355f60
to
c78f946
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Add the
isStartedproperty to notifiers similar to the current android implementation, to check whether Bugsnag has been initialisedChangeset
Added
isStartedto the following notifiersTesting
Added appropriate unit tests for each notifier