-
Notifications
You must be signed in to change notification settings - Fork 252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PLAT-7663] Fix state/metadata set in renderer config not being cleared #1893
Merged
yousif-bugsnag
merged 10 commits into
next
from
PLAT-7663/electron-renderer-client-clear-state
Dec 23, 2022
Merged
[PLAT-7663] Fix state/metadata set in renderer config not being cleared #1893
yousif-bugsnag
merged 10 commits into
next
from
PLAT-7663/electron-renderer-client-clear-state
Dec 23, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yousif-bugsnag
commented
Dec 21, 2022
imjoehaines
reviewed
Dec 21, 2022
Co-authored-by: Joe Haines <hello@joehaines.co.uk>
Co-authored-by: Joe Haines <hello@joehaines.co.uk>
Co-authored-by: Joe Haines <hello@joehaines.co.uk>
yousif-bugsnag
commented
Dec 21, 2022
"user": { | ||
"id": "{REGEX:[0-9a-f]{64}}" | ||
}, | ||
"context": "Runner", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you clear the renderer context it reverts to the default context, which is the html <title>
tag
imjoehaines
approved these changes
Dec 22, 2022
yousif-bugsnag
deleted the
PLAT-7663/electron-renderer-client-clear-state
branch
December 23, 2022 13:02
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Any state/metadata that was added in a renderer's configuration could no be removed from that renderer
This is because we send the renderer config values to the main process, but they were also stored locally in the renderer client (because it’s using the same code as all other JS platforms)
This means both the renderer and main processes had a copy of the state, but methods like
clearMetadata
andclearFeatureFlags
only talk to the main processThis affected
user
,context
metadata
andfeatureFlags
configChangeset
Updated
plugin-electron-renderer-client-state-updates
to clear any state from the renderer client once it has been synched to the main processTesting
user
,context
metadata
andfeatureFlags
set in renderer config