Skip to content
This repository has been archived by the owner on Dec 4, 2018. It is now read-only.

Add code support to node #65

Closed
snmaynard opened this issue Oct 6, 2015 · 3 comments
Closed

Add code support to node #65

snmaynard opened this issue Oct 6, 2015 · 3 comments

Comments

@snmaynard
Copy link
Contributor

We should add support for code in stacktrace
@jmshal
Copy link
Contributor

jmshal commented Nov 4, 2015

I really want to have a look at implementing this - no promises on time. Is there anything that needs to be done on the server side in order to hook this up?

@jmshal
Copy link
Contributor

jmshal commented Nov 4, 2015

I assume it would work exactly the same way as the PHP notifier does - https://github.com/bugsnag/bugsnag-php/blob/dc2e0b6092806c59bd33ef6c6aa74332762ff659/src/Bugsnag/Stacktrace.php#L95?

@jmshal
Copy link
Contributor

jmshal commented Nov 5, 2015

PR coming later...

screen shot 2015-11-05 at 1 21 16 pm

jmshal pushed a commit to jacobmarshall-etc/bugsnag-node that referenced this issue Nov 5, 2015
Add support for sending code snippets for each frame in the stacktrace [
487d542 
Fixes bugsnag#65]
jmshal added a commit to jacobmarshall-etc/bugsnag-node that referenced this issue Nov 13, 2015
@jmshal
Change frame.directory to frame.path (full path) [bugsnag#65]
f3eb385
kattrali added a commit that referenced this issue Nov 20, 2015
@kattrali
Merge pull request #67 from jacobmarshall/issue/code-support
4903953 
Add support for sending code [Fixes #65]
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@snmaynard @jmshal