Prepare for kepler #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A couple of fixes for code that I've already added and tested.
Related to #3 that already was reviewed and tested in canary, but doesn't include the logic for inverting the order of symbols in lookup, this was a hacky fix I added when we were trying to align the results of this version with the legacy version we currently use. I think it's best not to include that here as itt might cause confusion or even result in an incorrect symbol being returned.
Related to changes in #1 In this PR I made changes to add methods to obtain the compilation directory. The location had moved and we use it to normalize file paths. However in canary I found these bugs with the code that I added. Both effectively nullptrs.