Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installing and building issues since updating to npm@5 #177

Closed
GentlemanHal opened this issue Jun 5, 2017 · 0 comments
Closed

Installing and building issues since updating to npm@5 #177

GentlemanHal opened this issue Jun 5, 2017 · 0 comments
Labels
for developers Changes that make development easier help wanted Changes the team requires more information or help to resolve
Milestone

Comments

@GentlemanHal
Copy link
Member

GentlemanHal commented Jun 5, 2017

After updating to npm@5 the build starting breaking, it just seems to be doing some really strange stuff with the package-lock.json file.

Locally it seemed to randomly install some packages but not others. I resolved this by manually installing every single package, which was tedious but I thought if I at least managed to create the correct lock file it would work for everyone else. Unfortunately the build still failed on CI, you can see the details and my attempts to fix it. I eventually got the build green with some minor workarounds (manually installing semver in CI scripts).

I assumed this would be OK for the short term, but after trying to update some dependencies the build started breaking all over again. So for now I've worked around the issue by ignoring the package-lock.json file so it behaves more like previous npm versions.

There are 2 TODO comments marked with this issue number in the code that need to be removed once we figure out the correct solution.

@GentlemanHal GentlemanHal added for developers Changes that make development easier help wanted Changes the team requires more information or help to resolve labels Jun 5, 2017
@GentlemanHal GentlemanHal changed the title npm@5 breaking CI Installing and building issues since updating to npm@5 Jun 9, 2017
GentlemanHal added a commit that referenced this issue Nov 12, 2017
@GentlemanHal GentlemanHal added this to the v1.0.0 milestone Nov 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
for developers Changes that make development easier help wanted Changes the team requires more information or help to resolve
Projects
None yet
Development

No branches or pull requests

1 participant