Skip to content

unity-setup@v1.2.2 #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 30, 2025
Merged

unity-setup@v1.2.2 #29

merged 4 commits into from
Jul 30, 2025

Conversation

StephenHodgson
Copy link
Member

  • fix version matching

- fix version matching
@Copilot Copilot AI review requested due to automatic review settings July 30, 2025 23:06
@StephenHodgson StephenHodgson requested a review from a team as a code owner July 30, 2025 23:06
Copilot

This comment was marked as outdated.

@StephenHodgson StephenHodgson requested a review from Copilot July 30, 2025 23:15
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes version matching in the Unity setup action by implementing exact version matching first before falling back to caret range matching, and corrects a method name typo.

  • Improves version matching logic to prioritize exact matches over semver range matching
  • Fixes a typo in architecture string handling from toLocaleLowerCase() to toLowerCase()
  • Updates package version to v1.2.2

Reviewed Changes

Copilot reviewed 3 out of 6 changed files in this pull request and generated 1 comment.

File Description
src/unity-version.ts Implements exact version matching first, then fallback to caret range only for x.0.0 versions
src/unity-hub.ts Moves editor path check earlier and fixes method name typo
package.json Bumps version to 1.2.2
Comments suppressed due to low confidence (1)

src/unity-version.ts:53

  • [nitpick] The variable names minorIsZero and patchIsZero could be more descriptive. Consider renaming to isMinorZero and isPatchZero to follow boolean naming conventions.
    let minorIsZero = false, patchIsZero = false;

@StephenHodgson StephenHodgson merged commit df5fb35 into main Jul 30, 2025
7 of 25 checks passed
@StephenHodgson StephenHodgson deleted the dev branch July 30, 2025 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant