Make parsing initializers throw errors on failure

[czechboy0]

Currently some of them assert, some of them fail more gracefully. This needs to be unified with the new Swift 2 error handling system.

[cojoj]

I think this one should be a more global approach and try to replace any NSError return pointer be replaced by throws.

I suggest changing this while writing tests but we need to find a way how to test throwing methods to fully cover them... My idea is to write two tests per throwing method - in first test correct path and in the latter the path which throws exception.

We should create new ErrorType enum which will resemble what happened and probably these methods will be optional or will return optionals.

[cojoj]

@czechboy0 I think this one should be marked as a blocker right now because whatever we'll try to implement we'll be basing on exisinting XcodeServerEntity classes.

[czechboy0]

In light of this, I suggest we slow down on migrating the JSON parsing initializers to throw, because the code will become pretty ugly. I think we should focus on other issues before they fix it and we'll be able to do it the way it should have been all along. What do you think, @cojoj and @esttorhe?

[esttorhe]

I totally agree. The code looks cluttered and FUGLY as hell; would rather keep it «failable» but clean.

[czechboy0]

This issue is now blocked, we're waiting for Swift to become sane about throwing out of initializers without initializing all properties.

[esttorhe]

@czechboy0 perhaps remove the up-for-grabs until this is «unblocked»?

[czechboy0]

Good point 👍

[pmkowal]

I know that we are waiting for some Swift changes now, but when I run the test below with the "//\\https://127.0.0.1" value as a host parameter I receive EXC_BAD_ACCESS.

    func testDictionaryInit() {
        XCTempAssertNoThrowError("Failed to initialize the server configuration") {
            let json = [
                "host": "//\\https://127.0.0.1",
                "user": "ICanCreateBots",
                "password": "superSecr3t"
            ]

            let config = try XcodeServerConfig(json: json)

            XCTAssertEqual(config!.host, "https://127.0.0.1", "Should create proper host address")
            XCTAssertEqual(config!.user!, "ICanCreateBots")
            XCTAssertEqual(config!.password!, "superSecr3t")
        }
    }

Maybe in this case we could set JSONSerializable init method as non failable, like below, what do you think?

public protocol JSONSerializable {
    init(json: NSDictionary) throws
    func jsonify() -> NSDictionary
}