-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UPPERCASE instead of PascalCase in IDS? #132
Comments
There might be applications that are not schema-aware and only can go by the instance definitions from the .ifc file which is uppercase. I'm not sure how realistic that is, but that is what we discussed at the time. |
That was indeed the reason for the decision. |
What about ifcxml? |
I would at any time vote for PascalCase over uppercase when strings are concatenated parts. Any software can go from PascalCase to UPPERCASE but the reverse is not possible without consulting a schema. I believe it's even more important for predefined types then for entities. |
@janbrouwer +1 from me! |
the IFC specification for identifiers in EXPRESS is indeed not case sensitive, in ifcXML however it is. Also the candidate spec says that IDS should be applicable in principle also to other schemas (maybe gml, gbXML?) - and then all UPPERCASE ? so yes, +1 from me as well. |
Because of regexes in the patterns, implementers are going to have quite a bit of work to do, with any of the choices:
Just making strings UPPERCASE when saving from the UI is not enough, because we will have to include some logic to tell apart the metacharacters of regexes: E.g.:
PascalCase carries more information (PC to UC can be done, not vice versa), but that is also more error prone if end users are typing freely (especially in regexes), so UPPERCASE will probably result in fewer invalid IDS files. @aothms, I think that the argument for applications that are not schema-aware, is weaker than it was in the past, since we have introduced The choice we make, I think, should depend on what makes most resilient ecosystem, from an end user perspective. Personally, I think that making the tests case-insensitive would deliver the best user experience, but I acknowledge that it would be the most complex implementation, particularly for UIs. |
I wouldn't disagree with that, I was thinking the same actually.
That is also most inline with the express semantics. Express is case-insensitive. I think most regex implementations have an option/flag to ignore case [0] [1]. So you wouldn't have to do case normalization on the pattern (potentially triggering changes when doing \W -> \w.) I think there is a point for case insensitivity on schema names (what about pset and prop names?) but it's also potentially surprising when then model values are handled case sensitively (users might not always be able to tell the difference). |
This might change in the future, depending on buildingSMART#132, but for the time being `IfcBuildingStorey` is invalid.
This might change in the future, also depending from a parallel conversation happening on buildingSMART#132, but for the time being 'name' is not a valid attribute name; it should be capitalized ('Name').
This might change in the future, depending on #132, but for the time being `IfcBuildingStorey` is invalid.
* Entity name should be UPPERCASE This might change in the future, depending on #132, but for the time being `IfcBuildingStorey` is invalid. * Attribute name should match case with schema This might change in the future, also depending from a parallel conversation happening on #132, but for the time being 'name' is not a valid attribute name; it should be capitalized ('Name'). * Fixed documentation samples. - Uppercase for types in enumeration - Mismatch of case for 'Name' (was 'name') - totalDigits is not valid for xs:string (use length instead) - formatting of xs:annotation * index on allPr: 612d376 Merge branch 'pr/invalidEntityName' into allPr * Fixed min and max Occurrence id Development. * Development samples are all ok.
The group decided that for simplicity we can keep it UPPERCASE for version 1.0. |
Is there some reason to keep UPPERCASE instead of PascalCase for a class identification within the IDS specification, as shown in the Candidate Standard Report - January 2023?
The text was updated successfully, but these errors were encountered: