78 testcase floating point numbers tolerance #317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
removed attribute and property tests using fixed 1e6 tolerance, replaced with relative precision (according to #294)
remove omitted tests with a fixed tolerance
As per #309 replace underscore with dash.
This reverts commit 3704984.
This reverts commit da38da8.
…floating-point-numbers-tolerance
As per #309 replace underscore with dash.
as per #315, the exclusive comparison was hitting the tolerance 1e-6
corresponds to the already updated scripts.md file
|
Hello @atomczak, |
|
@atomczak, |
|
I would merge this to develop, because if fixes the naming convention, which seems critical. At that point we will also get feedback from implementers on the nature of the tests. |
CBenghi
approved these changes
Jun 10, 2024
|
@atomczak I'll leave it to you to merge, since you are more familiar with the matter. For this one, I think sooner rather than later. Even if it has mistakes, it is an improvement on the current state of |
…//github.com/buildingSMART/IDS into 78-testcase-floating-point-numbers-tolerance
This was referenced Jun 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.