Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add file explorer to pack-interact workflow #1326

Merged
merged 4 commits into from
Dec 6, 2021

Conversation

aemengo
Copy link
Contributor

@aemengo aemengo commented Nov 15, 2021

Summary

Adds a dive-style container layers explorer to --interactive mode, but delineated by buildpack

Output

Screen Shot 2021-11-10 at 10 47 54 PM

Documentation

  • Should this change be documented?
    • Yes, see #___
    • No
    • At some point

Related

Resolves #___

@github-actions github-actions bot added type/chore Issue that requests non-user facing changes. type/enhancement Issue that requests a new feature or improvement. labels Nov 15, 2021
@github-actions github-actions bot added this to the 0.23.0 milestone Nov 15, 2021
@aemengo aemengo force-pushed the pack-interact-mode-still-going branch 5 times, most recently from 4c3474c to c6b9415 Compare November 29, 2021 17:30
@aemengo aemengo marked this pull request as ready for review November 29, 2021 17:34
@aemengo aemengo requested a review from a team as a code owner November 29, 2021 17:34
Copy link
Member

@dfreilich dfreilich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From a UX perspective, this is fabulous. I really appreciated how, even before you added in a toolbar for what commands are valid, that the colors of the buildpacks changed when you were able to select them. I thought that was a very nice signifier.

internal/termui/detect.go Outdated Show resolved Hide resolved
@aemengo
Copy link
Contributor Author

aemengo commented Nov 30, 2021

@dfreilich You still had good feedback about showing a keymap - at least for Ctrl-C. I haven't forgotten; it will be addressed in a subsequent PR.

@aemengo aemengo force-pushed the pack-interact-mode-still-going branch 2 times, most recently from ebf9ccd to a77706b Compare December 6, 2021 00:02
@codecov
Copy link

codecov bot commented Dec 6, 2021

Codecov Report

❗ No coverage uploaded for pull request base (main@52a3caa). Click here to learn what that means.
The diff coverage is 76.04%.

❗ Current head 32bafa1 differs from pull request most recent head 9d648bc. Consider uploading reports for the commit 9d648bc to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1326   +/-   ##
=======================================
  Coverage        ?   80.60%           
=======================================
  Files           ?      146           
  Lines           ?     9534           
  Branches        ?        0           
=======================================
  Hits            ?     7684           
  Misses          ?     1366           
  Partials        ?      484           
Flag Coverage Δ
os_linux 79.33% <76.04%> (?)
os_macos 76.70% <69.59%> (?)
os_windows 80.47% <76.04%> (?)
unit 80.60% <76.04%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

@aemengo aemengo force-pushed the pack-interact-mode-still-going branch from a77706b to ec58768 Compare December 6, 2021 01:02
Anthony Emengo added 3 commits December 5, 2021 20:16
Signed-off-by: Anthony Emengo <aemengo@vmware.com>
accomodate the fact that ANALYZE now comes before DETECT

Signed-off-by: Anthony Emengo <aemengo@vmware.com>
Signed-off-by: Anthony Emengo <aemengo@vmware.com>
@aemengo aemengo force-pushed the pack-interact-mode-still-going branch from ec58768 to 32bafa1 Compare December 6, 2021 01:17
@dfreilich dfreilich merged commit cb57fea into buildpacks:main Dec 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/chore Issue that requests non-user facing changes. type/enhancement Issue that requests a new feature or improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants