Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

specify to use semver with buildpack versions in buildpack.toml #72

Closed
danielleadams opened this issue Jan 28, 2020 · 7 comments
Closed

Comments

@danielleadams
Copy link
Member

The specs don't specify the versioning conventions that should be used with buildpacks, even though https://github.com/buildpacks/libbuildpack/blob/b2e4a9ef07aff26c430dfac2fbc928ee4164af35/buildpack/info.go#L27 expects a semver.

We could also include a definition of what types of changes would update the major/minor/patches (or this could go in the docs).

@retrohacker
Copy link

https://github.com/buildpacks/spec/blob/master/buildpack.md#build-plan-toml

Came here to ask something similar. Thanks for the link @danielleadams this helps a lot ❤️

Reading the current docs it seems like the "plan" would require each buildpack to do version detection on behalf of it's dependencies, but being able to say 'I need any Node.js runtime semver compatible with the 14 release line' would be powerful.

@nebhale
Copy link
Contributor

nebhale commented May 16, 2020

@danielleadams I seem to remember that we’d decided on semver syntax, but not semver semantics. Did you plan on submitting a PR to the spec for this?

@danielleadams
Copy link
Member Author

@nebhale Yes, I can do that. However, this will make breaking changes to the spec (even though it won't to the API). Are there other steps I need to take for breaking spec changes besides submitting a pull request?

@nebhale
Copy link
Contributor

nebhale commented May 22, 2020

No other steps necessary. We'll handle moving it around so that it goes into the appropriate version of the specification to manage the breakage.

@danielleadams
Copy link
Member Author

Cool - I'll make a PR then.

@hone hone added the needs-pr label Jun 3, 2020
@danielleadams
Copy link
Member Author

Made the pull request here: #85

@ekcasey
Copy link
Member

ekcasey commented Jun 24, 2020

Resolved by 4ddee61

@ekcasey ekcasey closed this as completed Jun 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants