Update spec to specify expected version format #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joe Kutner <jpkutner@gmail.com>
Signed-off-by: Joe Kutner <jpkutner@gmail.com>
Signed-off-by: Joe Kutner <jpkutner@gmail.com>
* the source of these binding will be platform specific Signed-off-by: Emily Casey <ecasey@pivotal.io>
The platform should be responsible for injecting the bindings
Signed-off-by: Joe Kutner <jpkutner@gmail.com>
Signed-off-by: Joe Kutner <jpkutner@gmail.com>
Signed-off-by: Joe Kutner <jpkutner@gmail.com>
Signed-off-by: Joe Kutner <jpkutner@gmail.com>
Added a project.toml extension
Previously, the specification required a "tags" file that contained a set of arbitrary data. This hasn't been used for anything particularly useful to date, and it has been pointed out that allowing arbitrary files in metadata can achieve the same ends. Because of these observations, this change removes tags from the specification. Signed-off-by: Ben Hale <bhale@pivotal.io> Signed-off-by: Ben Hale <bhale@vmware.com>
Signed-off-by: Ben Hale <bhale@vmware.com>
Signed-off-by: Ben Hale <bhale@vmware.com>
…uildpacks#35: https://github.com/buildpacks/rfcs/blob/master/text/0035-buildpack-versions.md Signed-off-by: Danielle Adams <danielle.adams@heroku.com>
danielleadams
force-pushed
the
update-buildpack-version-specs
branch
from
44eda24
to
3148b5d
Compare
nebhale
approved these changes
Jun 3, 2020
hone
reviewed
Jun 3, 2020
hone
approved these changes
Jun 3, 2020
nebhale
approved these changes
Jun 4, 2020
|
@danielleadams Can you please do a rebase and force push to clear up the DCO issue? There needs to be a signoff line for every commit. |
Co-authored-by: Terence Lee <hone02@gmail.com> Signed-off-by: Danielle Adams <danielle.adams@heroku.com>
danielleadams
force-pushed
the
update-buildpack-version-specs
branch
from
f235649
to
d85f3c0
Compare
jkutner
approved these changes
Jun 8, 2020
|
Resolved by 4ddee61 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates spec following RFC #35 that will add version format guidance to buildpack authors: https://github.com/buildpacks/rfcs/blob/master/text/0035-buildpack-versions.md
Addresses: #72