PubSubException can have a cause, PubSubConfig removed, Convenience m… #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ethod for sending id, content added to Publisher
akshaisarma
requested changes
Aug 24, 2017
| * | ||
| * @param n The number of Subscribers requested. | ||
| * @return The {@link List} of n Subscribers wired as required. | ||
| * @return List of n Subscribers wired as required. |
| * Send a message with an ID and content. | ||
| * | ||
| * @param id The ID associated with the message. | ||
| * @param content The content of the message. |
There was a problem hiding this comment.
Use {@link PubSubException} in this and all other Javadocs in this file?
There was a problem hiding this comment.
I was wrong. You can't use this for throws. Thanks for the fix.
| * | ||
| * @param id The ID of the message to be marked as committed. | ||
| * @param sequence The sequence number of the message to be committed. | ||
| * @param id The ID of the message to be marked as committed. |
There was a problem hiding this comment.
There is extra indentation here and on the line below
| } | ||
|
|
||
| @Test(expectedExceptions = NullPointerException.class) | ||
| public void testNoIdIllegalCreation() { |
akshaisarma
approved these changes
Aug 24, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PubSubException can have a cause, PubSubConfig removed, Convenience method for sending id, content added to Publisher.