Skip to content

New http client #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 18 commits into from
Apr 3, 2018
Merged

New http client #21

merged 18 commits into from
Apr 3, 2018

Conversation

NathanSpeidel
Copy link
Member

No description provided.

@coveralls
Copy link

coveralls commented Mar 29, 2018 •
edited
Loading

Coverage Status

Coverage decreased (-0.002%) to 99.566% when pulling 2358e17 on NathanSpeidel:new-http-client into 085c3a1 on yahoo:master.

hbxie
hbxie reviewed Mar 29, 2018
View reviewed changes
Copy link
Contributor

@hbxie hbxie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be better if we support retry when failed to GET/POST.

@NathanSpeidel NathanSpeidel merged commit 90a2893 into bullet-db:master Apr 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@akshaisarma akshaisarma akshaisarma approved these changes

+1 more reviewer

@hbxie hbxie hbxie approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@akshaisarma akshaisarma

@hbxie hbxie

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@NathanSpeidel @coveralls @akshaisarma @hbxie