Changing shouldBuffer and time based window emit logic #24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NathanSpeidel
approved these changes
Apr 10, 2018
| * buffer the results in the Join stage for a bit for each window as results trickle in. The issue with the latter | ||
| * approach is that you will slowly add the buffer time to the duration of your windows in your Join stage and | ||
| * eventually you will get two windows in one. The former approach does not have this problem. However, that approach | ||
| * could lead you to drop results for record based windows due to the result. To solve these, you should buffer |
There was a problem hiding this comment.
How about However, that approach could lead to results sent immediately from the filter stage being dropped in the join stage if the query is still being delayed.
| * could lead you to drop results for record based windows due to the result. To solve these, you should buffer | ||
| * the final results for all queries for whom {@link #shouldBuffer()} is true. And you can use the negation of | ||
| * {@link #shouldBuffer()} to find out if this kind of query can be started after a bit of delay. This delay will | ||
| * ensure that results from the Filter phase always start for time based windows. To aid you in doing this, you can |
There was a problem hiding this comment.
This sentence This delay will ensure that results from the Filter phase always start for time based windows. is a little confusing. Did you mean something like This delay will ensure that results from the filter phase are collected in their entirety before emitting from the join phase.?
|
Code changes look great. I just had a couple suggestions for comments. 👍 |
hbxie
approved these changes
Apr 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.