Skip to content

This assertion is not necessarily true anymore #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 12, 2018
Merged

This assertion is not necessarily true anymore #26

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions src/test/java/com/yahoo/bullet/windowing/AdditiveTumblingTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,6 @@ public void testResetting() throws Exception {
long newCloseTime = additiveTumbling.nextCloseTime;
Assert.assertTrue(resetTime > started);
Assert.assertTrue(newCloseTime >= originalCloseTime + 1);
Assert.assertTrue(newCloseTime >= resetTime);
// Aggregation should NOT have been reset
Assert.assertEquals(strategy.getResetCalls(), 0);
}
Expand All @@ -150,7 +149,6 @@ public void testResettingInPartitionMode() throws Exception {
long newCloseTime = additiveTumbling.nextCloseTime;
Assert.assertTrue(resetTime > started);
Assert.assertTrue(newCloseTime >= originalCloseTime + 1);
Assert.assertTrue(newCloseTime >= resetTime);
// Aggregation should have been reset
Assert.assertEquals(strategy.getResetCalls(), 1);
}
Expand Down
2 changes: 0 additions & 2 deletions src/test/java/com/yahoo/bullet/windowing/TumblingTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,6 @@ public void testResetting() throws Exception {
long newCloseTime = tumbling.nextCloseTime;
Assert.assertTrue(resetTime > started);
Assert.assertTrue(newCloseTime >= originalCloseTime + 1);
Assert.assertTrue(newCloseTime >= resetTime);
Assert.assertEquals(strategy.getResetCalls(), 1);
}

Expand All @@ -149,7 +148,6 @@ public void testResettingForPartition() throws Exception {
long newCloseTime = tumbling.nextCloseTime;
Assert.assertTrue(resetTime > started);
Assert.assertTrue(newCloseTime >= originalCloseTime + 1);
Assert.assertTrue(newCloseTime >= resetTime);
Assert.assertEquals(strategy.getResetCalls(), 1);
}

Expand Down