Pluggable BulletRecord #28
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
June 5, 2018 18:26
added 12 commits
June 7, 2018 18:49
hbxie
reviewed
Jun 14, 2018
| public BulletConfig(String file) { | ||
| super(file, DEFAULT_CONFIGURATION_NAME); | ||
| VALIDATOR.validate(this); | ||
| bulletRecordProvider = BulletRecordProvider.from((String) get(RECORD_PROVIDER_CLASS_NAME)); |
There was a problem hiding this comment.
| public BulletConfig() { | ||
| super(DEFAULT_CONFIGURATION_NAME); | ||
| VALIDATOR.validate(this); | ||
| bulletRecordProvider = BulletRecordProvider.from((String) get(RECORD_PROVIDER_CLASS_NAME)); |
akshaisarma
requested changes
Jun 14, 2018
| sketch = threshold != null ? new FrequentItemsSketch(errorType, maxMapSize, threshold.longValue(), size) : | ||
| new FrequentItemsSketch(errorType, maxMapSize, size); | ||
| sketch = threshold != null ? new FrequentItemsSketch(errorType, maxMapSize, threshold.longValue(), size, config.getBulletRecordProvider()) : | ||
| new FrequentItemsSketch(errorType, maxMapSize, size, config.getBulletRecordProvider()); |
There was a problem hiding this comment.
You can store a reference to the record provider above before the ternary since that seems to the be convention here
| return new QuantileSketch(64, 6, Distribution.Type.QUANTILE, 10, bulletRecordProvider); | ||
| } | ||
|
|
||
| private BulletRecordProvider bulletRecordProvider; |
There was a problem hiding this comment.
Move this to before the methods
|
|
||
| @BeforeMethod | ||
| private void setup() { | ||
| bulletRecordProvider = new BulletConfig().getBulletRecordProvider(); |
There was a problem hiding this comment.
We don't need a before method. Just use a static variable. Ditto for other test files
src/test/resources/test_config.yaml
Outdated
| bullet.pubsub.class.name: "com.yahoo.bullet.pubsub.MockPubSub" | ||
| bullet.pubsub.class.name: "com.yahoo.bullet.pubsub.MockPubSub" | ||
| bullet.pubsub.rest.connect.timeout.ms: 88 | ||
| bullet.record.provider.class.name: "com.yahoo.bullet.record.AvroBulletRecordProvider" |
There was a problem hiding this comment.
The default should be enough no?
added 3 commits
June 14, 2018 16:20
hbxie
approved these changes
Jun 18, 2018
akshaisarma
approved these changes
Jun 18, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.