Using record extractField. Helpers to RecordBox #68
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0aix
requested changes
Nov 21, 2018
| } | ||
|
|
||
| private <T> boolean isNotInstance(Class<T> clazz, Object object) { | ||
| return object != null && !clazz.isInstance(object); |
There was a problem hiding this comment.
clazz != null (?)
clazz.isInstance already does a non-null check
| Map<String, T> newMap = new LinkedHashMap<>(map.size()); | ||
| for (Map.Entry<String, Object> entry : map.entrySet()) { | ||
| Object object = entry.getValue(); | ||
| if (isNotInstance(clazz, object)) { |
There was a problem hiding this comment.
above.
could just replace with !clazz.isInstance(object)
There was a problem hiding this comment.
String key = entry.getKey()
and
newMap.put(key, ...)
| if (casted == null) { | ||
| throw new RuntimeException("Object " + casted + " is not an instance of class " + clazz.getName()); | ||
| } | ||
| newMap.put(entry.getKey(), (Map<String, T>) entry.getValue()); |
There was a problem hiding this comment.
might as well use key instead of entry.getKey()
| Objects.requireNonNull(entries); | ||
| List<T> newList = new ArrayList<>(entries.length); | ||
| for (Object entry : entries) { | ||
| if (isNotInstance(clazz, entry)) { |
0aix
reviewed
Nov 21, 2018
| for (Map.Entry<String, Object> entry : map.entrySet()) { | ||
| Object object = entry.getValue(); | ||
| if (isNotInstance(clazz, object)) { | ||
| if (!clazz.isInstance(entry)) { |
0aix
approved these changes
Nov 21, 2018
hbxie
approved these changes
Nov 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #47