Allowing additional configs. Fixing config values. Renamed some configs #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hbxie
reviewed
Oct 5, 2017
| // Required common Kafka properties for producers and consumers | ||
| public static final Set<String> KAFKA_PROPERTIES = new HashSet<>(asList(BOOTSTRAP_SERVERS, CONNECTIONS_MAX_IDLE_MS)); | ||
|
|
||
| // Producer specific properties |
| KAFKA_PRODUCER_PROPERTIES.addAll(KAFKA_PROPERTIES); | ||
| } | ||
|
|
||
| // Consumer specific properties |
| @@ -1,33 +1,65 @@ | |||
| # These are required Kafka settings for consumers and producers | |||
There was a problem hiding this comment.
Nit: Add a period for each sentence in your comments.
There was a problem hiding this comment.
I added periods to sentences. If it's a title, it looks weird, so I left it out.
hbxie
previously approved these changes
Oct 5, 2017
|
|
||
| # Kafka PubSub properties | ||
| # The number of messages that can received before at least one commit is needed. | ||
| bullet.pubsub.kafka.consumer.max.uncommitted.messages: 50 |
There was a problem hiding this comment.
This doesn't need to be a string?
There was a problem hiding this comment.
This is a Bullet config so I can keep proper types. Kafka params are better off being Strings since Kafka casts. Otherwise, they need to be the exact type (it doesn't do Longs to Integer etc). That being said, this param is confusing because it has the same prefix as the Kafka consumer so I'll change the consumer in the prefix.
| bullet.pubsub.kafka.consumer.request.timeout.ms: "35000" | ||
|
|
||
| # Kafka PubSub properties | ||
| # The number of messages that can received before at least one commit is needed. |
hbxie
approved these changes
Oct 17, 2017
NathanSpeidel
approved these changes
Oct 17, 2017
|
Tested this on a secure Kafka cluster. Seems to be working. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will wait to merge till I test this out but feel free to take a look