Skip to content

Conversation

OGKevin
Copy link
Contributor

@OGKevin OGKevin commented Aug 7, 2017

Adds readme for tests.

Running tests from command line seems to be a pain in the but tho 😢.

@OGKevin OGKevin self-assigned this Aug 7, 2017
@OGKevin OGKevin requested a review from dnl-blkv August 7, 2017 10:27
Copy link
Contributor

@dnl-blkv dnl-blkv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments :)

To run the tests you must first setup the test configuration JSON. The example
of a configuration file is located at [`src/test/config.example.properties`](./config.example.properties).
In order to make use of the configuration file, please copy the example to the
same directory, fill in your sandbox user data and rename the copy to `config.properties`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Period in the end of sentence? :P

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😁 I mean it sooo clear that that is the end of the sentence tho 🤔 😝



## Scenarios

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do not need this newline :)

of a configuration file is located at [`src/test/config.example.properties`](./config.example.properties).
In order to make use of the configuration file, please copy the example to the
same directory, fill in your sandbox user data and rename the copy to `config.properties`

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do not need this newline :)

are also tested :thumbs_up:.

## Configuration

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do not need this newline :)

same directory, fill in your sandbox user data and rename the copy to `config.properties`

## Execution

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do not need this newline :)

@OGKevin OGKevin requested a review from dnl-blkv August 7, 2017 10:39
Copy link
Contributor

@dnl-blkv dnl-blkv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@dnl-blkv dnl-blkv merged commit c7c179a into develop Aug 7, 2017
@dnl-blkv dnl-blkv deleted the feature/test_readme branch August 7, 2017 11:04
@dnl-blkv
Copy link
Contributor

dnl-blkv commented Aug 7, 2017

@andrederoos

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants