-
Notifications
You must be signed in to change notification settings - Fork 30
Added tests readme #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few comments :)
src/test/README.md
Outdated
To run the tests you must first setup the test configuration JSON. The example | ||
of a configuration file is located at [`src/test/config.example.properties`](./config.example.properties). | ||
In order to make use of the configuration file, please copy the example to the | ||
same directory, fill in your sandbox user data and rename the copy to `config.properties` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Period in the end of sentence? :P
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😁 I mean it sooo clear that that is the end of the sentence tho 🤔 😝
src/test/README.md
Outdated
|
||
|
||
## Scenarios | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We do not need this newline :)
of a configuration file is located at [`src/test/config.example.properties`](./config.example.properties). | ||
In order to make use of the configuration file, please copy the example to the | ||
same directory, fill in your sandbox user data and rename the copy to `config.properties` | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We do not need this newline :)
src/test/README.md
Outdated
are also tested :thumbs_up:. | ||
|
||
## Configuration | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We do not need this newline :)
src/test/README.md
Outdated
same directory, fill in your sandbox user data and rename the copy to `config.properties` | ||
|
||
## Execution | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We do not need this newline :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Adds readme for tests.
Running tests from command line seems to be a pain in the but tho 😢.