Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add response id to error messages from failed requests  #59

Closed
OGKevin opened this issue Dec 24, 2017 · 0 comments
Closed

Add response id to error messages from failed requests  #59

OGKevin opened this issue Dec 24, 2017 · 0 comments
Assignees
@OGKevin
Labels
enhancement
Milestone
0.12.5

Comments

@OGKevin
Copy link
Contributor

OGKevin commented Dec 24, 2017 •
edited
Loading

Steps to reproduce:

  1. Make a bad request
  2. Try and get the response id from the X-Bunq-Server-Response-Id header.

What should happen:

  1. There is a way to get the response id to debug this error on bunq's side if needed.

What happens:

  1. 👆 is not possible.

Logs

  • Logs 'no logs

Extra info:

References
@OGKevin OGKevin added this to the 0.12.5 milestone Dec 24, 2017
@OGKevin OGKevin self-assigned this Dec 24, 2017
OGKevin added a commit that referenced this issue Dec 26, 2017
@OGKevin
Moved http related tests to the http test folder. (#59)
72c09a8
OGKevin added a commit that referenced this issue Dec 26, 2017
@OGKevin
Added error constant in case response id header retrieval fails. (#59)
635f75d
OGKevin added a commit that referenced this issue Dec 26, 2017
@OGKevin
Added method to retrieve response header from failed request. (#59)
d650c59
OGKevin added a commit that referenced this issue Dec 26, 2017
@OGKevin
Added response id parameter to exception base class. (#59)
0972b4d
OGKevin added a commit that referenced this issue Dec 26, 2017
@OGKevin
Include response id in error message format. (#59)
5999e88
OGKevin added a commit that referenced this issue Dec 26, 2017
@OGKevin
Pass response id to exceptions in exception factory. (#59)
aa15279
OGKevin added a commit that referenced this issue Dec 26, 2017
@OGKevin
Added test to ensure that response id retrieval at request failure pa…
3a427a4 
…sses. (#59)
@OGKevin OGKevin mentioned this issue Dec 26, 2017
Merged
1 task
OGKevin added a commit that referenced this issue Dec 26, 2017
@OGKevin
Added missing docstrings. (#59)
284cc29
OGKevin added a commit that referenced this issue Dec 29, 2017
@OGKevin
Moved http related tests to the http test folder. (#59)
e036aef
OGKevin added a commit that referenced this issue Dec 29, 2017
@OGKevin
Added error constant in case response id header retrieval fails. (#59)
7568934
OGKevin added a commit that referenced this issue Dec 29, 2017
@OGKevin
Added method to retrieve response header from failed request. (#59)
e63aeb2
OGKevin added a commit that referenced this issue Dec 29, 2017
@OGKevin
Added response id parameter to exception base class. (#59)
c2d288a
OGKevin added a commit that referenced this issue Dec 29, 2017
@OGKevin
Include response id in error message format. (#59)
4817075
OGKevin added a commit that referenced this issue Dec 29, 2017
@OGKevin
Pass response id to exceptions in exception factory. (#59)
a727616
OGKevin added a commit that referenced this issue Dec 29, 2017
@OGKevin
Added test to ensure that response id retrieval at request failure pa…
ef780ad 
…sses. (#59)
OGKevin added a commit that referenced this issue Dec 29, 2017
@OGKevin
Added missing docstrings. (#59)
a3ef206
OGKevin added a commit that referenced this issue Dec 29, 2017
@OGKevin
Added missing argument for UnknownApiErrorException. (#59)
1041e0a
OGKevin added a commit that referenced this issue Dec 30, 2017
@OGKevin
Removed plural methods and constatns. (#59)
979b853
OGKevin added a commit that referenced this issue Jan 2, 2018
@OGKevin
Reoredered docstring parameters. (#59)
f3324e3
OGKevin added a commit that referenced this issue Jan 2, 2018
@OGKevin
Use assertRaises to make code cleaner. (#59)
d5d92c6
OGKevin added a commit that referenced this issue Jan 2, 2018
@OGKevin
Removed redundant assertions. (#59)
177f605
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@OGKevin OGKevin

Labels
enhancement
Projects
None yet
Milestone
0.12.5
Development

No branches or pull requests
1 participant
@OGKevin