Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Response is missing response headers and pagination #9

Closed
dnl-blkv opened this issue Aug 8, 2017 · 2 comments
Closed

Response is missing response headers and pagination #9

dnl-blkv opened this issue Aug 8, 2017 · 2 comments
Assignees
@dnl-blkv
Labels
enhancement
Milestone
v.0.10.0

Comments

@dnl-blkv
Copy link
Contributor

dnl-blkv commented Aug 8, 2017

How to Reproduce

  1. Make a valid listing request to bunq API via the Python SDK
  2. Make a valid get/put/post/delete request to bunq API via the Python SDK

What Should Happen

  1. The response contains response headers and pagination
  2. The response contains response headers

What Happens

  1. The response does not contain response header nor pagination
  2. The response does not contain response header

Notes

  1. The structural fix would be to introduce BunqResponse object which, besides the response model, includes the response headers and pagination
@dnl-blkv dnl-blkv self-assigned this Aug 8, 2017
@OGKevin OGKevin added this to the v.0.10.0 milestone Aug 8, 2017
@OGKevin
Copy link
Contributor

OGKevin commented Aug 8, 2017

Related to #8

dnl-blkv added a commit that referenced this issue Aug 8, 2017
@dnl-blkv
#9 move to BunqResponse
2b84e2e
dnl-blkv added a commit that referenced this issue Aug 8, 2017
@dnl-blkv
#9 switch tests to BunqResponse
b498d2e
dnl-blkv added a commit that referenced this issue Aug 8, 2017
@dnl-blkv
#9 Add missing generated model properties and objects
4e2bcb7
dnl-blkv added a commit that referenced this issue Aug 9, 2017
@dnl-blkv
#9 fix location of BunqResponse
2c945ae
andrederoos added a commit that referenced this issue Aug 14, 2017
@andrederoos
Merge pull request #10 from bunq/9-bunq-response
356d5ca 
#9 Introduce BunqResponse
@OGKevin
Copy link
Contributor

OGKevin commented Aug 18, 2017

Closing as #10 has been merged.

@OGKevin OGKevin closed this as completed Aug 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dnl-blkv dnl-blkv

Labels
enhancement
Projects
None yet
Milestone
v.0.10.0
Development

No branches or pull requests
2 participants
@dnl-blkv @OGKevin