Skip to content

Fix notification adapter and test. #126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 21, 2020
Merged

Fix notification adapter and test. #126

merged 2 commits into from
Feb 21, 2020

Conversation

FNG21
Copy link
Contributor

@FNG21 FNG21 commented Feb 20, 2020

Fix notification adapter and test.

@FNG21 FNG21 requested a review from angelomelonas February 20, 2020 14:30
angelomelonas
angelomelonas approved these changes Feb 20, 2020
View reviewed changes
Copy link
Contributor

@angelomelonas angelomelonas left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and working locally.

@angelomelonas
Copy link
Contributor

@nickvandegroes this has been approved. Will you please merge it? 😄

@FNG21 FNG21 merged commit 896830b into develop Feb 21, 2020
@angelomelonas angelomelonas deleted the feature/sdk_python#125_fix_notification_adapter branch September 16, 2020 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@angelomelonas angelomelonas angelomelonas approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@FNG21 @angelomelonas @nickvandegroes