Add missing _user_payment_service_provider variable with the value None to session_server #135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ne to session_server I ran into this issue bunq#134. When I add the line in this commit it fixes it for me.
|
@angelomelonas @lexym @nickvandegroes could any of you take a look at this PR? It has been open for 2.5 months and there has been no reaction even though there have been new commits and even a new release. |
lexym
approved these changes
Aug 4, 2020
angelomelonas
approved these changes
Aug 4, 2020
|
Hey @siccovansas, you're right! It was missing but it isn't any more 👍 Thanks for helping us fix it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into this issue #134. When I add the line in this commit it fixes it for me. I have no idea if this is indeed a bug on Bunq's side and if this pull request fixes (all of) it, but to me it seems like it :). Please check if I'm correct.
Also the code in
sdk_python/bunq/sdk/json/session_server_adapter.pycontains quite a few mentions ofUSER_PAYMENT_SERVER_PROVIDER, I guess this should beUSER_PAYMENT_SERVICE_PROVIDER?This PR closes/fixes the following issues: