Add strictly typed responses; fix circular dependencies; improve namespaces #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnl-blkv
changed the title
OGKevin
reviewed
Sep 26, 2017
| :rtype: None | ||
| """ | ||
|
|
||
| import datetime |
There was a problem hiding this comment.
Why are we importing inside a function ?
There was a problem hiding this comment.
It is an exception made for the initializer to make sure no code from within the module is executed before it is needed. Reducing chances of circular deps!
| @@ -29,25 +29,25 @@ class InstallationAdapter(converter.JsonAdapter): | |||
| @classmethod | |||
| def deserialize(cls, target_class, array): | |||
| """ | |||
| :type target_class: model.Installation|type | |||
| :type target_class: core.Installation|type | |||
There was a problem hiding this comment.
Is this notation used every where else in this SDK as well ? 🙊
There was a problem hiding this comment.
Notation, as in |type? Yes, absolutely! For long time already :)
Same goes for module.Class! 👍
|
@OGKevin all questions answered |
andrederoos
approved these changes
Oct 6, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.