Feature/improve decoder bunq/sdk python#42 #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JvanHengel
reviewed
Dec 20, 2017
bunq/__init__.py
Outdated
| for class_string in dir(endpoint): | ||
| class_ = getattr(endpoint, class_string) | ||
|
|
||
| if not inspect.isclass(class_): |
| @@ -65,8 +67,12 @@ class TestNotificationUrl(bunq_test.BunqSdkTestCase): | |||
| def execute_notification_url_test(self, | |||
| file_path, | |||
| class_name, | |||
| getter_name): | |||
| getter_name, | |||
| sub_class_expected_object_name=None, | |||
There was a problem hiding this comment.
This is python standard for optional arguments . 👍
bunq/sdk/json/adapters.py
Outdated
|
|
||
| class AnchoredObjectModelAdapter(converter.JsonAdapter): | ||
|
|
||
| _ERROR_MODEL_NOT_FOUND = '{} is not in endpoint nor object' |
|
@JvanHengel Please 👀 again |
|
@andrederoos All yours please 👀 |
andrederoos
requested changes
Dec 21, 2017
bunq/__init__.py
Outdated
| @@ -14,6 +14,8 @@ def initialize_converter(): | |||
| from bunq.sdk.json import adapters | |||
| from bunq.sdk.json import converter | |||
| from bunq.sdk.model.generated import object_ | |||
| from bunq.sdk.model.generated import endpoint | |||
| import inspect | |||
There was a problem hiding this comment.
move import statement up
|
@andrederoos yours |
andrederoos
approved these changes
Dec 21, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #50
Closes #42