(bunq/sdk_python#60) improve issue and pr template #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OGKevin
commented
Dec 25, 2017
.github/PULL_REQUEST_TEMPLATE.md
Outdated
| @@ -0,0 +1,8 @@ | |||
| [//]: # (Thanks for opening this pull request! Before you proceed please make sure that you've an issue that explains what this pull request will do. | |||
| Make sure that all your commits link this issue e.g "My commit \(bunq/sdk_php#<issue nr>\)". | |||
| If this pr is changing files that are located in "src/Model/Generated" then this PR will be closed as these files must/can only be changed on bunq's side.) | |||
There was a problem hiding this comment.
This path isn't correct tho 🤔
OGKevin
changed the title
|
@epels all yours please 👀 |
OGKevin
force-pushed
the
feature/bunq/sdk_python#60-imporve-issue-and-pr-tempplate
branch
from
e49eff9
to
5bf1ddc
Compare
|
@andrederoos all yours please 👀 |
andrederoos
approved these changes
Jan 2, 2018
andrederoos
changed the title
andrederoos
deleted the
feature/bunq/sdk_python#60-imporve-issue-and-pr-tempplate
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #60