-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add version pinning functionality #132
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix rubocop offenses: https://travis-ci.org/buo/homebrew-cask-upgrade/builds/482972228
Hey @dongyuzheng , thanks a lot for your contribution! It's nice that someone found a time to do that. Please do me a favour and change the description here so that instead of lust listing those issues change it to Thanks! 👍 |
Hi @ondrejfuhrer, does my latest commit give desired output for your case? |
lib/bcu/options.rb
Outdated
options.list_pins = true | ||
end | ||
|
||
opts.on("--pin APP", "App to pin") do |app| |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everywhere we / Homebrew uses CASK
, I don't see a reason why we should introduce new naming? I saw that in one of the versions you had used that, any particular reason why you decided to use different naming?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I saw that the code/documentation used app
in some places, so I change them to app
to be consistent. But I changed it to cask
now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me 👍 Now it has to wait for @buo
i think the pinned file should be better in the |
@muescha Not sure if that would make any difference. Not even the Homebrew core is using a home folder for that and they are pinning it within Homebrew structure, so I don't see any important reason why would you do that. Also if you would remove the tap it would leave those files on the home folder which is not very clean. |
I think @ondrejfuhrer is right, there is |
ok - you are right, it should be the same as the homebrew core behaviour |
Why
I found myself needing this when I didn't want to update
java8
.This PR resolves #108, resolves #93, resolves #90, resolves #72
Not included in this PR
Currently you can pin casks that are not installed. So you can pin
asdasfsadasd
Usage
Example usage