Remove hacks around Minitest internals, make peace with Minitest.autorun #514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of trying to hack around Minitest internals, we'll simply hook into the way that they internally call Minitest.run(ARGV) by replacing ARGV with our desired test arguments. This is arguably a hack because we're mangling ARGV but Minitest has executed with ARGV explicitly passed in for at least two major releases so we'll go with it for now.
|
Where are you seeing Rails require minitest/autorun? That loads the spec DSL and Rails has been very careful not to do that. |
|
My mistake, https://github.com/rails/rails/blob/master/railties/lib/rails/test_help.rb#L6 => https://github.com/rails/rails/blob/master/activesupport/lib/active_support/testing/autorun.rb |
|
Gotcha. This seems like a decent compromise. Interested to know what @zenspider thinks. |
This uses the same strategy as Minitest, namely replacing ARGV and running via RSpec's native autorun hook.
latortuga
added a commit
that referenced
this pull request
May 19, 2015
Remove hacks around Minitest internals, make peace with Minitest.autorun
This was referenced Sep 16, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to run Minitest via
Minitest.run. Rails requires'minitest/autorun'when requiring'rails/test_help'which means invokingMinitest.run(our_arguments)will cause tests to get run twice, once with our arguments and once with ARGV via autorun.Instead of trying to hack around Minitest class variables and prevent autorun from working, we'll stop fighting it and let Minitest run our desired tests by replacing ARGV with our desired test arguments and letting autorun invoke the tests when the child processes exit. This is still a bit of an introspection of Minitest's API because we're mangling ARGV but Minitest has executed with ARGV explicitly in autorun for at least two major releases so we'll go with it for now.
Previously discussed here.
@zenspider I welcome any feedback on this mechanism for hooking into
autorun. I'm trying to balance working out of the box with standard Railstest_helperagainst mucking with Minitest's internals and I'm definitely open to other ways of passing proper arguments intoMinitest.run.@blowmage I would also appreciate your thoughts on this.