Fix Travis by removing excess Gem mention #593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A gem shouldn't need to mention itself in its Gemfile and this seems to be causing problems with our Travis CI builds.
|
r? @doy |
|
I'm going to land this since other things are blocking on getting the CI suite working and the vagrant gem is something of an undocumented feature. @doy happy to take post-merge discussion. |
|
I feel like this was necessary for... something, but I don't remember what (it's been almost a year). Given that we're no longer using Vagrant, I don't really see myself spending time working on this, so I'm fine with whatever you need to do. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A gem shouldn't need to mention itself in its Gemfile and this seems to be causing problems with our Travis CI builds.