Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backport fix for IME bugs #745

Merged
merged 1 commit into from
Oct 6, 2020
Merged

backport fix for IME bugs #745

merged 1 commit into from
Oct 6, 2020

Conversation

tnmt
Copy link

@tnmt tnmt commented Sep 30, 2020

Hi, I noticed this PR #738, and this PR is based on v0.13.x.

I want to fix the same problem in v0.12.x versions, so I forked from v0.12.4 code base and apply the fix same as #738.

How do you think about it?
Could you merge and release in 0.12.5 tag?

Thanks.

@tnmt
Copy link
Author

tnmt commented Sep 30, 2020

sorry for the bad base branch specification.

I'll recreate the other PR.

@tnmt tnmt closed this Sep 30, 2020
@ZeeJab ZeeJab reopened this Oct 6, 2020
@ZeeJab ZeeJab changed the base branch from master to release-0-12 October 6, 2020 12:41
@ZeeJab ZeeJab merged commit 3c20cc9 into bustle:release-0-12 Oct 6, 2020
@tnmt tnmt deleted the backport-fix-ime-bug branch October 6, 2020 12:57
@ZeeJab
Copy link
Contributor

ZeeJab commented Oct 6, 2020

Hi @tnmt, I created the release-0-12 branch to facilitate patch releases for the 0.12 series like this. I also reopened your PR and retargeted it at this new branch. Closes #746

@tnmt
Copy link
Author

tnmt commented Oct 7, 2020

Thank you for merge and release v0.12.5 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants