Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Comment form should not be cleared on upvote #807

Closed
espoem opened this issue Oct 16, 2017 · 1 comment
Closed

Comment form should not be cleared on upvote #807

espoem opened this issue Oct 16, 2017 · 1 comment
Labels
bug

Comments

@espoem
Copy link
Contributor

espoem commented Oct 16, 2017

comment-vote

Expected behavior

The content in the comment form should stay untouched after upvoting the post.

Actual behavior

Comment form is cleared after upvoting the post.

How to reproduce

  1. Start writing a comment for a post. Don't submit it yet.
  2. Upvote the post.
  3. The comment form is cleared.
  • Browser: Chrome 61.0.3163.100
  • Operating system: Windows 10
SimpliciTea added a commit to SimpliciTea/busy that referenced this issue Oct 22, 2017
@SimpliciTea
Comment form should not be cleared on upvote busyorg#807
4fdb094 
Proposed fix --
  -- move this.setState({ inputValue: '' }) from
     componentWillReceiveProps to onSubmit method

I believe that this creates the intended behavior
@karthik-awebon
Copy link
Contributor

I started looking at this issue. Thanks

karthik-awebon added a commit to karthik-awebon/busy that referenced this issue Nov 13, 2017
@karthik-awebon
Fix for issue busyorg#807 - Comment form should not be cleared on upvote
d472bf3
@karthik-awebon karthik-awebon mentioned this issue Nov 13, 2017
Merged
karthik-awebon added a commit to karthik-awebon/busy that referenced this issue Nov 14, 2017
@karthik-awebon
Fix for issue busyorg#807 - Comment form should not be cleared on upvote
bf9aa07
karthik-awebon added a commit to karthik-awebon/busy that referenced this issue Nov 14, 2017
@karthik-awebon
Fixed fix ESLint errors - busyorg#807
8834f95
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@Sekhmet @karthik-awebon @bonustrack @espoem