Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use production and development index files #1001

Merged
merged 3 commits into from
Nov 3, 2017

Conversation

Sekhmet
Copy link
Contributor

@Sekhmet Sekhmet commented Nov 3, 2017

Fixes #997

Changes:

  • dist/ folder has been deleted
  • templates/index.html is used for development purposes
  • templates/production_index.html is used for production

@Sekhmet Sekhmet self-assigned this Nov 3, 2017
@bonustrack bonustrack temporarily deployed to busy-nd-pr-1001 November 3, 2017 20:57 Inactive
@bonustrack
Copy link
Contributor

Isn't more common to have a dist folder instead of templates?

@Sekhmet
Copy link
Contributor Author

Sekhmet commented Nov 3, 2017

For built files I think so, but they are not built yet (at least one of them). production-index.html will be built using html-webpack-plugin first, and then moved to public/ folder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants