Fix reputation wrap issue on mobile #842 #1016
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robert9g
changed the title
Sekhmet
approved these changes
Nov 5, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #842 .
Changes:
.UserHeader__userto havemargin: 0 !important;on small screens. This margin has no relevance on small screens, since the text is center aligned and has no elements on the sides..UserHeader__user__usernameto28pxon small screensObservations:
The
!importantwas necessary because some media queries were defined before normal style inUserHeader.less. Normally media queries are defined after the normal style(non-media). In the present case the normal style would override the media queries, therefore!importantwas needed.I wanted to move the media queries at the bottom of the file, so that the
!importantwill not be needed, but wasn't sure if the reason for this would be clear enough.In case this is wanted, it can be easily changed.