Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Image upload validation #1017

Merged
merged 6 commits into from
Nov 10, 2017
Merged

Image upload validation #1017

merged 6 commits into from
Nov 10, 2017

Conversation

Sekhmet
Copy link
Contributor

@Sekhmet Sekhmet commented Nov 5, 2017

Fixes #1014.

Changes:

  • Validate if image is actually an image and has size of at most 50MB (changeable in configuration) in Editor, CommentForm and EmbeddedCommentForm for drag'n'drop, pasting, and file dialog.
  • If image didn't pass validation display notification

image

@Sekhmet Sekhmet added the bug label Nov 5, 2017
@bonustrack bonustrack temporarily deployed to busy-nd-pr-1017 November 5, 2017 11:39 Inactive
@bonustrack bonustrack temporarily deployed to busy-nd-pr-1017 November 5, 2017 20:31 Inactive
@bonustrack bonustrack temporarily deployed to busy-nd-pr-1017 November 10, 2017 22:48 Inactive
@Sekhmet Sekhmet merged commit 2b5b63e into busyorg:new-design Nov 10, 2017
@Sekhmet Sekhmet deleted the image-upload-validation branch November 10, 2017 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bonustrack bonustrack bonustrack approved these changes

@jm90m jm90m jm90m approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Sekhmet @jm90m @bonustrack