Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve votes sorting #1025

Merged
merged 1 commit into from
Nov 11, 2017
Merged

Improve votes sorting #1025

merged 1 commit into from
Nov 11, 2017

Conversation

Sekhmet
Copy link
Contributor

@Sekhmet Sekhmet commented Nov 5, 2017

Changes:

  1. Remove parseInt from sortVotes.
    Using implicit conversion is faster (~20 times faster). This results
    in ~1300ms faster render when scrolling in feed and loading new posts twice:
    Before:
    image
    After:
    image

@Sekhmet
Remove parseInt from sortVotes
48e54e1 
Using implicit conversion is faster (~20 times faster). This results
in ~1300ms faster render when scrolling in feed and loading new posts
twice.
@Sekhmet Sekhmet self-assigned this Nov 5, 2017
jm90m
jm90m previously approved these changes Nov 6, 2017
View reviewed changes
Copy link
Contributor

@jm90m jm90m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@bonustrack bonustrack temporarily deployed to busy-nd-pr-1025 November 6, 2017 07:47 Inactive
@Sekhmet Sekhmet removed the PR: WIP label Nov 11, 2017
@Sekhmet Sekhmet changed the title Improve feed performance Improve votes sorting Nov 11, 2017
@Sekhmet Sekhmet merged commit 00cc179 into busyorg:ssr Nov 11, 2017
@Sekhmet Sekhmet deleted the feed-rendering branch November 11, 2017 15:50
Sekhmet added a commit that referenced this pull request Nov 11, 2017
@Sekhmet
Remove parseInt from sortVotes (#1025) (#1069)
e3a0910
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jm90m jm90m jm90m left review comments

Assignees

@Sekhmet Sekhmet

Labels
refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Sekhmet @jm90m @bonustrack