Sets limit to comment indents | 5th level #1090
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1088 .
Changes:
Comment__replies--never-indent
@media @small
from.Comment__text
so that comment avatars would show up after 5th level.Comment__replies--no-indent
margin to use the@comment-text-offset-small
varObservations:
I know that there were issues between the comment avatars (#883) and the
code
blocks (#771), and removingoverflow:hidden;
was needed to properly rendercode
block. But this should be fixed because we calculate the width for each.Comment__text
element.I tested on these pages:
code
comments:/test/@hellosteem/5ihr1p-test#@hellosteem/re-hellosteem-5ihr1p-test-20171018t132820462z
/cesky/@bucipuci/narocna-kapca-challenge-captcha
@minnowpond
comment with thecode
element in it:/philosophy/@michellecarter/what-is-the-highest-power